1080863 - 'Pico Speech Synth', contract ID '@mozilla.org/synthpico;1' does not implement nsIObserver.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gregor Wagner [:gwagner]]

During B2G startup:
I/GeckoConsole(  209): While creating services from category 'profile-after-change', service for entry 'Pico Speech Synth', contract ID '@mozilla.org/synthpico;1' does not implement nsIObserver.

Comment 1

[Karl Tomlinson (:karlt)]

Selecting component based on other webspeech bugs.

Comment 2

[Gregor Wagner [:gwagner]]

Eitan, can you take care of this?

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Make nsPicoService an observer and initialize on profile-after-change. r=

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8504933 [details] [diff] [review]
Make nsPicoService an observer and initialize on profile-after-change. r=

NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsISpeechService)
->
NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsIObserver)


(I prefer to use the first inherited interface as the canonical nsISupports)

Comment 5

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b35949ca31c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cf230fd2ae8b for non-unified bustage:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3002574&repo=mozilla-inbound

Comment 7

[Eitan Isaacson [:eeejay]]

New patch shows no breakage:
https://tbpl.mozilla.org/?tree=Try&rev=e089bc972b20

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Make nsPicoService an observer and initialize on profile-after-change. r=

I simply moved the constructor back out of the header so it doesn't use forward declarations.

Comment 9

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87192f7f5774

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/87192f7f5774