Closed Bug 1080909 Opened 11 years ago Closed 11 years ago

Win64 VS2013 TestAudioEventTimeline fails because expf(-inf) returns -inf

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: away, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Do not accept a zero time constant when calling AudioParam.setTargetAtTime in order to avoid the division by zero later on; r=padenot
2.16 KB, patch
padenot
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=49373629&tree=Date Win64 VS2013 only. It boils down to the expf call at AudioEventTimeline::ExponentialApproach. When timeConstant==0, we basically do expf(-1.0/0.0), for which MSVCR120!expf returns a negative infinity. Ehsan, are you the owner of this test?
Flags: needinfo?(ehsan.akhgari)
Assignee: nobody → ehsan.akhgari
Flags: needinfo?(ehsan.akhgari)
Attachment #8503432 - Flags: review?(padenot)
Attachment #8503432 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/e1ec08bcb588
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
<https://tbpl.mozilla.org/?tree=Date&rev=0c480befd4ea> seems to suggest that this error is still on Date... Did my patch not make that merge, or did it not work?
Flags: needinfo?(dmajor)
You missed by a few minutes :-/ Next time, Gadget, next time...
Flags: needinfo?(dmajor)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: