Closed Bug 1080921 Opened 5 years ago Closed 5 years ago

WebGL2: Support non-power-of-two textures

Categories

(Core :: Canvas: WebGL, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: dvander, Assigned: dvander)

Details

Attachments

(1 file)

No description provided.
PR for conformance test is here: https://github.com/KhronosGroup/WebGL/pull/743

The DoDeferredImageInitialization change is to avoid having to check HasUninitializedImageData at all its callsites.
Attachment #8502885 - Flags: review?(jgilbert)
Comment on attachment 8502885 [details] [diff] [review]
bug1080921-npot-textures.patch

Review of attachment 8502885 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLTexture.cpp
@@ +179,4 @@
>  
>          GLsizei size = std::max(imageInfo.mWidth, imageInfo.mHeight);
>  
> +        // Find floor(log2(size)). (ES 3.0.4, 3.8 - Mipmapping).

Yay for spec quoting!
Attachment #8502885 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/9fe4537e244f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.