Closed
Bug 1080921
Opened 11 years ago
Closed 11 years ago
WebGL2: Support non-power-of-two textures
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(1 file)
|
15.64 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
PR for conformance test is here: https://github.com/KhronosGroup/WebGL/pull/743
The DoDeferredImageInitialization change is to avoid having to check HasUninitializedImageData at all its callsites.
Attachment #8502885 -
Flags: review?(jgilbert)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8502885 [details] [diff] [review]
bug1080921-npot-textures.patch
Review of attachment 8502885 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/WebGLTexture.cpp
@@ +179,4 @@
>
> GLsizei size = std::max(imageInfo.mWidth, imageInfo.mHeight);
>
> + // Find floor(log2(size)). (ES 3.0.4, 3.8 - Mipmapping).
Yay for spec quoting!
Attachment #8502885 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•