Developer Edition ( 35 ) should not offer to turn on e10s

RESOLVED WORKSFORME

Status

()

Firefox
Developer Tools
RESOLVED WORKSFORME
3 years ago
3 years ago

People

(Reporter: canuckistani, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Devtools are not currently 100% solid on e10s, so we should not offer to turn it on. We can revisit for 36 or 37.
I believe we don't need to do anything here. The pref is conditional on E10S_TESTING_ONLY, which is only set for NIGHTLY_BUILD:

http://dxr.mozilla.org/mozilla-central/source/configure.in#3473

NIGHTLY_BUILD is set when the version number ends in a1:

http://dxr.mozilla.org/mozilla-central/source/configure.in#3438

Aurora channel builds end in a2, so it should be omitted automatically. Manual Developer Edition builds from m-c or other repos however will have that on. Do we care about those? I assume no, as it's nice to keep testing e10s ourselves.
(In reply to Panos Astithas [:past] (overloaded, please needinfo) from comment #1)
> I believe we don't need to do anything here. The pref is conditional on
> E10S_TESTING_ONLY, which is only set for NIGHTLY_BUILD:
> 
> http://dxr.mozilla.org/mozilla-central/source/configure.in#3473
> 
> NIGHTLY_BUILD is set when the version number ends in a1:
> 
> http://dxr.mozilla.org/mozilla-central/source/configure.in#3438
> 
> Aurora channel builds end in a2, so it should be omitted automatically.
> Manual Developer Edition builds from m-c or other repos however will have
> that on. Do we care about those? I assume no, as it's nice to keep testing
> e10s ourselves.

Thanks - just wanted to make sure given the havoc this played for Remy's evaluation. Closing.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
(In reply to Panos Astithas [:past] (overloaded, please needinfo) from comment #1)
> I believe we don't need to do anything here. The pref is conditional on
> E10S_TESTING_ONLY, which is only set for NIGHTLY_BUILD:

Did you actually test this? Bug 1085622 means that might not be actually working as it should :(
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
It's possible that bug only affects prefs though - I haven't heard any reports of the prompt appearing for Aurora builds.
I just checked things with an Aurora 35 build (is this the same as the Developer Build?). Bug 1085622 is present in the code, but it doesn't directly affect Aurora because:
 - It uses the traditional Preferences dialog instead of about:preferences, which doesn't have the e10s checkbox
 - The e10s prompt checks for UpdateChannel.get() == "nightly" and doesn't show up otherwise.

I'll check other instances of E10S_TESTING_ONLY to see if there's something else that would be a problem. I think if there is we should quickly uplift a patch to switch them to NIGHTLY_BUILD just to be double safe.
(In reply to :Felipe Gomes from comment #5)
>  - It uses the traditional Preferences dialog instead of about:preferences,
> which doesn't have the e10s checkbox

Ah - bug 1072181 is changing that (enabling in-content prefs on Aurora). But the checkbox showing up in prefs is not as serious as prompting.

>  - The e10s prompt checks for UpdateChannel.get() == "nightly" and doesn't
> show up otherwise.

OK, so we should be good here. Thanks for checking!
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.