Closed Bug 1081176 Opened 5 years ago Closed 5 years ago

Apply oauth key for loop contacts to debug and related builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox35 fixed)

RESOLVED FIXED
mozilla35
Tracking Status
firefox35 --- fixed

People

(Reporter: jesup, Assigned: jesup)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 file)

Currently the loop oauth key is only applied to opt/nightly builds; it should be applied to basically all builds on our servers.

Better would be abstract the location and move the enabling to either build/mozconfig.common, or abstract the location in a platform-specific include in each platform (kinda like win64 has common-win64).  Followup, though.
Attachment #8503237 - Flags: review?(catlee)
Comment on attachment 8503237 [details] [diff] [review]
Apply loop oauth keys to debug builds/etc

Review of attachment 8503237 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm - thanks!
Attachment #8503237 - Flags: review?(catlee) → review+
https://hg.mozilla.org/mozilla-central/rev/e5d3834c61a4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8503237 [details] [diff] [review]
Apply loop oauth keys to debug builds/etc

Approval Request Comment
[Feature/regressing bug #]: OAuth landing (for importing Gmail contacts)
[User impact if declined]:  I need to uplift this in case we have to use a debug build to track down a problem with importing contacts in Fx34 and to avoid testing confusion.  (These files are already in Opt builds.)  
[Describe test coverage new/current, TBPL]: Built in every push
[Risks and why]: This is low risk to update.
[String/UUID change made/needed]:None
Attachment #8503237 - Flags: approval-mozilla-aurora?
Attachment #8503237 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This landed prior to the uplift.
Attachment #8503237 - Flags: approval-mozilla-aurora+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.