1081180 - Build error: CodeGenerator.cpp:1309: error: undefined reference to 'JSInlineString::MAX_LENGTH_TWO_BYTE'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:garvan]

Forked from https://bugzilla.mozilla.org/show_bug.cgi?id=1068209 comment 14

The build error is:
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSFatInlineString::MAX_LENGTH_LATIN1'
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSFatInlineString::MAX_LENGTH_TWO_BYTE'
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSInlineString::MAX_LENGTH_LATIN1'
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSInlineString::MAX_LENGTH_TWO_BYTE'

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1001708

Link error due to statics + ternary operator when building fennec 

http://stackoverflow.com/questions/5446005/why-dont-static-member-variables-play-well-with-the-ternary-operator

Comment 1

[:garvan]

Attachment: bug1068209.patch

Changed ternary to if-statements

Comment 2

[Brian Hackett [Laid off!]]

Attachment: alternate

This patch fits in better sylistically and is easier to read, does this fix the problem for you?

Comment 3

[:garvan]

Comment on attachment 8503247 [details] [diff] [review]
alternate

Review of attachment 8503247 [details] [diff] [review]:
-----------------------------------------------------------------

Compiles, looks good

Comment 4

[Martyn Haigh (:mhaigh)]

Can confirm that this fixes my build.  Thanks!

Comment 5

[:garvan]

Can this get committed?

Comment 6

[Richard Newman [:rnewman]]

Attachment: Patch for landing.

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 8505575 [details] [diff] [review]
Patch for landing.

Tree is closed, otherwise I'd land this. Instead, here, have a correctly formatted patch.

Comment 8

[Richard Newman [:rnewman]]

Garvan, does this need uplift?

Comment 9

[:garvan]

For building Fennec Aurora on OS X, yes an uplift is needed.

Comment 10

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/be659580d14f

Comment 11

[Richard Newman [:rnewman]]

Flag for uplift when this goes green, Garvan.

Comment 12

[:garvan]

Richard, builds are green:
https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team&revision=f4a100d16452

[Tracking Requested - why for this release]:
For compiling Fennec 35 on OS X, without this syntax change, there is a build error.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be659580d14f

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40ea2e0e9385