Build error: CodeGenerator.cpp:1309: error: undefined reference to 'JSInlineString::MAX_LENGTH_TWO_BYTE'

RESOLVED FIXED in Firefox 35

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: garvan, Assigned: bhackett)

Tracking

33 Branch
Firefox 36
All
Android
Points:
---

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Forked from https://bugzilla.mozilla.org/show_bug.cgi?id=1068209 comment 14

The build error is:
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSFatInlineString::MAX_LENGTH_LATIN1'
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSFatInlineString::MAX_LENGTH_TWO_BYTE'
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSInlineString::MAX_LENGTH_LATIN1'
js/src/jit/CodeGenerator.cpp:1309: error: undefined reference to 'JSInlineString::MAX_LENGTH_TWO_BYTE'

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1001708

Link error due to statics + ternary operator when building fennec 

http://stackoverflow.com/questions/5446005/why-dont-static-member-variables-play-well-with-the-ternary-operator
(Reporter)

Comment 1

3 years ago
Created attachment 8503239 [details] [diff] [review]
bug1068209.patch

Changed ternary to if-statements
(Reporter)

Updated

3 years ago
Attachment #8503239 - Flags: review?(lucasr.at.mozilla)
(Assignee)

Comment 2

3 years ago
Created attachment 8503247 [details] [diff] [review]
alternate

This patch fits in better sylistically and is easier to read, does this fix the problem for you?

Updated

3 years ago
Flags: needinfo?(gkeeley)
(Reporter)

Updated

3 years ago
Attachment #8503239 - Attachment is obsolete: true
Attachment #8503239 - Flags: review?(lucasr.at.mozilla)
Flags: needinfo?(gkeeley)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8503247 [details] [diff] [review]
alternate

Review of attachment 8503247 [details] [diff] [review]:
-----------------------------------------------------------------

Compiles, looks good
Attachment #8503247 - Flags: review+
Can confirm that this fixes my build.  Thanks!
(Reporter)

Comment 5

3 years ago
Can this get committed?
Created attachment 8505575 [details] [diff] [review]
Patch for landing.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Assignee: rnewman → bhackett1024
OS: Mac OS X → Android
Hardware: x86 → All
Comment on attachment 8505575 [details] [diff] [review]
Patch for landing.

Tree is closed, otherwise I'd land this. Instead, here, have a correctly formatted patch.
Attachment #8505575 - Flags: review+
Attachment #8505575 - Flags: checkin?
Garvan, does this need uplift?
Keywords: checkin-needed
(Reporter)

Comment 9

3 years ago
For building Fennec Aurora on OS X, yes an uplift is needed.
https://hg.mozilla.org/integration/fx-team/rev/be659580d14f
Flag for uplift when this goes green, Garvan.
Keywords: checkin-needed
Attachment #8505575 - Flags: checkin? → checkin+
(Reporter)

Comment 12

3 years ago
Richard, builds are green:
https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team&revision=f4a100d16452

[Tracking Requested - why for this release]:
For compiling Fennec 35 on OS X, without this syntax change, there is a build error.
status-firefox35: --- → affected
tracking-firefox35: --- → ?
https://hg.mozilla.org/mozilla-central/rev/be659580d14f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
(Reporter)

Updated

3 years ago
Attachment #8505575 - Flags: approval-mozilla-aurora?
(Reporter)

Updated

3 years ago
status-firefox35: affected → ---
tracking-firefox35: ? → ---
status-firefox35: --- → affected
status-firefox36: --- → fixed
Attachment #8505575 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/40ea2e0e9385
status-firefox35: affected → fixed
You need to log in before you can comment on or make changes to this bug.