Closed
Bug 1081203
Opened 11 years ago
Closed 11 years ago
Remove dead #social-toolbar-item CSS since there is nothing called social-toolbar-item defined outside of the CSS
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: jaws, Assigned: himanshusingh.singh06, Mentored)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 2 obsolete files)
5.65 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/search?string=social-toolbar-item should show usages outside of CSS if it is going to be used within CSS.
Currently, it shows:
> social-toolbar-item
>
> Found 10 matching lines
> /browser/themes/osx/browser.css (View Hg log or Hg annotations)
>
> line 4371 -- #social-toolbar-item > .toolbarbutton-1 {
> line 4380 -- #social-toolbar-item > .toolbarbutton-1:-moz-locale-dir(ltr) {
> line 4383 -- #social-toolbar-item > .toolbarbutton-1:last-child:-moz-locale-dir(ltr) {
> line 4386 -- #social-toolbar-item > .toolbarbutton-1:-moz-locale-dir(rtl) {
> line 4389 -- #social-toolbar-item > .toolbarbutton-1:first-child:-moz-locale-dir(rtl) {
> line 4393 -- #social-toolbar-item > .toolbarbutton-1:-moz-locale-dir(ltr):first-child,
> line 4394 -- #social-toolbar-item > .toolbarbutton-1:-moz-locale-dir(rtl):last-child {
> line 4399 -- #social-toolbar-item > .toolbarbutton-1:-moz-locale-dir(rtl):first-child,
> line 4400 -- #social-toolbar-item > .toolbarbutton-1:-moz-locale-dir(ltr):last-child {
> line 4406 -- #social-toolbar-item > toolbaritem {
>
> Found 10 matching lines
Comment 1•11 years ago
|
||
Assuming you're right about this being a useless rule, this will make a nice good-first-bug.
Reporter | ||
Updated•11 years ago
|
Mentor: jaws
Whiteboard: [good first bug][lang=css]
Comment 2•11 years ago
|
||
Hey id like to work on this bug. How do i begin?
Updated•11 years ago
|
Flags: needinfo?(jaws)
Comment 3•11 years ago
|
||
If it is possible I would like to work on this bug as it would be my first? :)
Comment 4•11 years ago
|
||
So is for https://mxr.mozilla.org/mozilla-central/search?string=social-provider-button, this also doesn't seem to be used anywhere outside of CSS.
Hi I already have the builds set-up . Please could I work on this bug?
Thanks
Jesal
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #8503776 -
Flags: review?(jaws)
Reporter | ||
Comment 9•11 years ago
|
||
Comment on attachment 8503776 [details] [diff] [review]
1081203.patch
Review of attachment 8503776 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, this looks good. Can you also remove the following rules (as pointed out in comment #4): https://mxr.mozilla.org/mozilla-central/search?string=social-provider-button
Attachment #8503776 -
Flags: review?(jaws) → feedback+
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → himanshusingh.singh06
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #8503776 -
Attachment is obsolete: true
Attachment #8504465 -
Flags: review?(jaws)
Reporter | ||
Comment 11•11 years ago
|
||
Comment on attachment 8504465 [details] [diff] [review]
1081203.patch
Review of attachment 8504465 [details] [diff] [review]:
-----------------------------------------------------------------
This is close but it is missing the removal of the #social-provider-button rules from the /browser/themes/osx/browser.css stylsheet.
Attachment #8504465 -
Flags: review?(jaws) → feedback+
Assignee | ||
Comment 12•11 years ago
|
||
Attachment #8504465 -
Attachment is obsolete: true
Attachment #8504668 -
Flags: review?(jaws)
Reporter | ||
Comment 13•11 years ago
|
||
Comment on attachment 8504668 [details] [diff] [review]
1081203.patch
Review of attachment 8504668 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Thanks! I'll mark this as checkin-needed now, and it should be checked in to the fx-team integration branch within a day or two. Once it gets there, then it will get merged to mozilla-central within the next day or two. (All of this usually happens faster, but sometimes there are delays if patches introduce test failures). Once it's in the mozilla-central repository, it will show up in Firefox Nightly the next day.
Congratulations on your first patch. Thanks for sticking with it.
Attachment #8504668 -
Flags: review?(jaws) → review+
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 14•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
Comment 15•11 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #13)
> Congratulations on your first patch. Thanks for sticking with it.
That landed now in fx-team! Thanks for contributing to Mozilla!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 36
You need to log in
before you can comment on or make changes to this bug.
Description
•