1081207 - [Messages] We never revoke the blob URL for the attachments

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

Since bug 983172 landed, we now leak the blobs used for images. This is quite bad.

* We'll leak when we display a thread containing MMS with images and then going back to the thread list
* We'll leak when sending a MMS with an image. We'll leak both the resized image and the original image.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: regression

Comment 2

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hey Julien,

In this patch I revoke object URL for the following cases:

* Composer: when attachment is removed (except for the case when it's removed with backspace, noted that on Github);
* Composer: when attachment is replaced;
* Composer: when composer is cleared (like in Send Message or Go Back case);
* ThreadUI: when user leaves ThreadUI panel.

Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8513727 [details] [review]
GitHub pull request URL

r=me with the nit in ThreadUI that is unnecessary in my opinion. Please argument if you think otherwise :)

Comment 4

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Comment on attachment 8513727 [details] [review]
> GitHub pull request URL
> 
> r=me with the nit in ThreadUI that is unnecessary in my opinion. Please
> argument if you think otherwise :)

Thanks for review! Added clarifying code comment as we agreed.

Master: https://github.com/mozilla-b2g/gaia/commit/4aedb73eef6eea1a6282d359b807b22b287ff269

Comment 5

[[:RJ]]

there is no STR's for this issue, and not enough information to verify if this is has landed.