If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

ASAN failures aren't recognized by mozharness as errors

RESOLVED INCOMPLETE

Status

Release Engineering
Mozharness
RESOLVED INCOMPLETE
3 years ago
4 months ago

People

(Reporter: jld, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3127] )

(Reporter)

Description

3 years ago
ASAN builds disable the crash reporter, so ASAN failures are directly indicated only by ASAN's log messages, which mozharness doesn't recognize as errors.  The process also exits, but if it's a child process and it fails in this way at a time that doesn't cause a test failure (if the test script is insufficiently strict, or if it's on a shutdown path after the test considers itself finished, or something like that) then the test run will be green on Treeherder/TBPL despite containing evidence of what could be a security issue.

I don't know if it would be appropriate to add this kind of thing to the "harness_error" regexp in TinderBoxPrintRe in mozharness/mozilla/testing/errors.py, alongside the regexp alternatives for LSAN messages, or if there's some other place that makes more sense.

Updated

3 years ago
Blocks: 1048775
(Reporter)

Updated

3 years ago
See Also: → bug 1082112
(Reporter)

Comment 1

3 years ago
Apparently this sort of works?  e.g., https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2490777&repo=try flags a line "INFO - SUMMARY: AddressSanitizer: heap-buffer-overflow ??:0 ??", but in that case there was also a test failure.  (Maybe bug 1081251 was unintentionally fixed?)

Also, that "??:0" looks like something tried to use addr2line, but misparsed the log and supplied an incorrect address (or used a stripped binary, or something like that).

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3117]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3117] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3122]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3122] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3127]

Updated

4 months ago
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.