1081243 - [Downloads] A recently download file can not be open

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[pete siphantong [:Petes]]

Attachment: dd.txt

Description: 
When the user open a recent download, the file will not open

Repro Steps:
1) Update a Flame to 20141010000201
2) Open Settings > downloads
3) Go to Browser, https://owd.tid.es/dm/
4) Download any file > Swipe the screen over the download list screen

Actual:
Unable to open a completed download

Expected:
open a completed download


Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13566/
See attached: video, logcat, https://www.youtube.com/watch?v=F3KS9iY4aZw

Comment 1

[pete siphantong [:Petes]]

This issue also reproduce on the Flame 2.2 KitKat Base (319mb) and the Flame 2.0 KitKat Base (319mb)(Full Flash), Unable to open a completed download.

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Flame 2.0 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.0
Build ID: 20141010000201
Gaia: 9791940d5093c37336dcd85f7e66e9a8445a218e
Gecko: 00d3c843aeec
Version: 32.0 (2.0)
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

Nominating this as a blocker. If the user downloads a file and then uses edge gestures to swipe over to the settings page to view the recently downloaded file, they should be able to open it without issue.

Comment 3

[Dietrich Ayala (:dietrich)]

This might be a regression - qawanted for a 1.4 branch check (downloads landed in either 1.3 or 1.4...).

This probably should block regardless because broken feature -> blocking+. Even if it's not a regression, then it's probably a broken new feature because edge gestures.

Comment 4

[Cody Roesch [:croesch]]

Bug also exists in flame 1.4. Unable to tap on a downloaded file to open it up.

Environmental Variables:
Device: Flame 1.4
BuildID: 20141002180522
Gaia: b06fee13c1d80bd2a463be1f2fb1d59169af9298
Gecko: ea144d59c01e
Version: 30.0 (1.4) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 5

[Manuel Casas Barrado [:mancas]]

Attachment: PR: User can open recent downloads

The main problem here is that the recent downloads are |DOMDownload| objects and its state once they have been downloaded is 'finalized' instead of 'succeeded', so when the user taps in the download, the case I've explained, is not defined

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8506859 [details] [review]
PR: User can open recent downloads

EJ, please help review the patch, thanks!

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8506859 [details] [review]
PR: User can open recent downloads

I think the patch is good to go, but we need to add tests for these cases.

Please help to add them, thanks !

Comment 8

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8506859 [details] [review]
PR: User can open recent downloads

I've added a unit test to cover this case. Let me know if we need more unit tests.

Thanks!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8506859 [details] [review]
PR: User can open recent downloads

Thanks Manuel !

r+

Comment 10

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/76fdc72e8cc69dcdbf0be36f6d741d68ba919514

Comment 11

[(PTO June 19-July 7) Ryan VanderMeulen]

Please request Gaia v2.0 and v2.1 approval on this when you get a chance.

Comment 12

[Manuel Casas Barrado [:mancas]]

Attachment: Patch for v2.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): This is not a regression
[User impact] if declined: Using edge gestures the user is not able to open a recent download and he/she must to restart the Setting app
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 13

[Manuel Casas Barrado [:mancas]]

Attachment: Patch for v2.1

Comment 14

[bhavana bajaj [:bajaj]]

Comment on attachment 8510957 [details] [review]
Patch for v2.0

Reqesting QA verification across branches as soon as this lands..

Comment 15

[(PTO June 19-July 7) Ryan VanderMeulen]

v2.1: https://github.com/mozilla-b2g/gaia/commit/d0dc69156e57116e242b5ecbb26d78bd8c19063c

Comment 16

[(PTO June 19-July 7) Ryan VanderMeulen]

v2.0: https://github.com/mozilla-b2g/gaia/commit/327cac98740f8085efaf29142b977088abe16dcf

Comment 17

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2, 2.1, 2.0.

Result: The user can switch to Download screen using edge gesture, and the downloaded file can be opened.

Flame 2.2

Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141027000202 
Gaia: 2183b4f3ec0eb47ab1f133c31732ec53b08ad253
Gecko: 43bee45176c4
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/327cac98740f8085efaf29142b977088abe16dcf

Comment 19

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been successfully verified on Woodduck 2.0 
See attachment: VIDEO0101.3gp
Reproducing rate: 0/5
Woodduck2.0 build:
Gaia-Rev        3a98f1287fa7b604891220ba5d86982ae8f9971e
Gecko-Rev       03d3ab62d5b07b915434f2d1d68495ad5915ecd2
Build-ID        20141120103003
Version         32.0