Replace HashMap with EnumMap where possible

RESOLVED FIXED in Firefox 35

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ckitching, Assigned: ckitching)

Tracking

unspecified
Firefox 35
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [upstream needed])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
See the javadocs for details. This leads to small performance improvements for freeee. (it essentially becomes an array keyed by enum ordinals)
(Assignee)

Comment 1

4 years ago
Created attachment 8503373 [details] [diff] [review]
Use EnumMap where possible
Attachment #8503373 - Flags: review?(rnewman)
(Assignee)

Comment 2

4 years ago
Created attachment 8503409 [details] [diff] [review]
Use EnumSet where possible

Can do it for Sets, too...
Attachment #8503409 - Flags: review?(rnewman)
Attachment #8503373 - Flags: review?(rnewman) → review+
Whiteboard: [upstream needed]
Comment on attachment 8503409 [details] [diff] [review]
Use EnumSet where possible

Review of attachment 8503409 [details] [diff] [review]:
-----------------------------------------------------------------

Upstreaming needed for both patches.
Attachment #8503409 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/efd2ce78cdeb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.