Closed Bug 1081287 Opened 10 years ago Closed 10 years ago

Replace HashMap with EnumMap where possible

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 35

People

(Reporter: ckitching, Assigned: ckitching)

Details

(Whiteboard: [upstream needed])

Attachments

(2 files)

Use EnumMap where possible
5.50 KB, patch
rnewman
: review+
Details | Diff | Splinter Review
Use EnumSet where possible
2.09 KB, patch
rnewman
: review+
Details | Diff | Splinter Review
See the javadocs for details. This leads to small performance improvements for freeee. (it essentially becomes an array keyed by enum ordinals)
Attachment #8503373 - Flags: review?(rnewman)
Can do it for Sets, too...
Attachment #8503409 - Flags: review?(rnewman)
Attachment #8503373 - Flags: review?(rnewman) → review+
Whiteboard: [upstream needed]
Comment on attachment 8503409 [details] [diff] [review] Use EnumSet where possible Review of attachment 8503409 [details] [diff] [review]: ----------------------------------------------------------------- Upstreaming needed for both patches.
Attachment #8503409 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/efd2ce78cdeb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: