Closed Bug 1081350 Opened 5 years ago Closed 5 years ago

|nsComputedDOMStyle::CreatePrimitiveValueForClipPath| can leak |val|

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: erahm, Assigned: krit)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, memory-leak, Whiteboard: [MemShrink:P3][CID 1244920])

Attachments

(1 file)

Blocks: 1072894
Component: Layout → CSS Parsing and Computation
Keywords: mlk
Ah, I moved it to the wrong line accidentally. Will fix.
Moved all nsROCSSPrimitiveValue* val = new nsROCSSPrimitiveValue calls right before their first usage in this block.
Attachment #8503801 - Flags: review?(dbaron)
Attachment #8503801 - Flags: review?(bzbarsky)
Comment on attachment 8503801 [details] [diff] [review]
clip-path-leak.patch

r=me
Attachment #8503801 - Flags: review?(dbaron)
Attachment #8503801 - Flags: review?(bzbarsky)
Attachment #8503801 - Flags: review+
Keywords: checkin-needed
Hi, can you provide a try run for this change, thanks!
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [MemShrink][CID 1244920] → [MemShrink:P3][CID 1244920]
https://hg.mozilla.org/mozilla-central/rev/7a05af7d4902
Assignee: nobody → krit
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.