Closed
Bug 1081350
Opened 10 years ago
Closed 10 years ago
|nsComputedDOMStyle::CreatePrimitiveValueForClipPath| can leak |val|
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: erahm, Assigned: krit)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, memory-leak, Whiteboard: [MemShrink:P3][CID 1244920])
Attachments
(1 file)
2.23 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|nsComputedDOMStyle::CreatePrimitiveValueForClipPath| [1] allocates a |nsROCSSPrimitiveValue| [2] and then early returns without freeing it [3]. [1] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/layout/style/nsComputedDOMStyle.cpp#l5179 [2] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/layout/style/nsComputedDOMStyle.cpp#l5215 [3] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/layout/style/nsComputedDOMStyle.cpp#l5217
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Ah, I moved it to the wrong line accidentally. Will fix.
Assignee | ||
Comment 2•10 years ago
|
||
Moved all nsROCSSPrimitiveValue* val = new nsROCSSPrimitiveValue calls right before their first usage in this block.
Attachment #8503801 -
Flags: review?(dbaron)
Attachment #8503801 -
Flags: review?(bzbarsky)
Comment 3•10 years ago
|
||
Comment on attachment 8503801 [details] [diff] [review] clip-path-leak.patch r=me
Attachment #8503801 -
Flags: review?(dbaron)
Attachment #8503801 -
Flags: review?(bzbarsky)
Attachment #8503801 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Hi, can you provide a try run for this change, thanks!
Keywords: checkin-needed
Assignee | ||
Comment 5•10 years ago
|
||
Link to try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0899533ee658
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a05af7d4902
Keywords: checkin-needed
Updated•10 years ago
|
Whiteboard: [MemShrink][CID 1244920] → [MemShrink:P3][CID 1244920]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a05af7d4902
Assignee: nobody → krit
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → mozilla36
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•