1081350 - |nsComputedDOMStyle::CreatePrimitiveValueForClipPath| can leak |val|

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Eric Rahm [:erahm]]

|nsComputedDOMStyle::CreatePrimitiveValueForClipPath| [1] allocates a |nsROCSSPrimitiveValue| [2] and then early returns without freeing it [3].

[1] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/layout/style/nsComputedDOMStyle.cpp#l5179
[2] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/layout/style/nsComputedDOMStyle.cpp#l5215
[3] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/layout/style/nsComputedDOMStyle.cpp#l5217

Comment 1

[Dirk Schulze]

Ah, I moved it to the wrong line accidentally. Will fix.

Comment 2

[Dirk Schulze]

Attachment: clip-path-leak.patch

Moved all nsROCSSPrimitiveValue* val = new nsROCSSPrimitiveValue calls right before their first usage in this block.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8503801 [details] [diff] [review]
clip-path-leak.patch

r=me

Comment 4

[Carsten Book [:Tomcat]]

Hi, can you provide a try run for this change, thanks!

Comment 5

[Dirk Schulze]

Link to try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0899533ee658

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a05af7d4902

Comment 7

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/7a05af7d4902