1081419 - WebGL2: Implement some miscellaneous parameters

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bugXX-misc-parameters.patch

This patch adds getParameter() support for MAX_UNIFORM_BLOCK_SIZE and MAX_VERTEX_UNIFORM_COMPONENTS. I'm not sure if we normally do conformance tests for things like this, but I've got one ready to go if so.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Yes, WebGL tries hard to cover everything with conformance tests. As you can see, WebGL 1 is covered quite extensively,
https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

https://github.com/KhronosGroup/WebGL/pull/747

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1081419-more-parameters.patch

Two more parameters (Khronos PR is updated as well).

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8504295 [details] [diff] [review]
bug1081419-more-parameters.patch

Review of attachment 8504295 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +156,5 @@
>  
>      if (IsWebGL2()) {
>          switch (pname) {
> +            case LOCAL_GL_MAX_SAMPLES:
> +            case LOCAL_GL_NUM_PROGRAM_BINARY_FORMATS:

We're not implementing program binaries in WebGL2, so drop this one. MAX_SAMPLES is fine.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1081419-misc-params.patch

rolled-up

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Patch with checkin info - LAND ME

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edabc76c30f5

Comment 8

[Carsten Book [:Tomcat]]

Comment on attachment 8504956 [details] [diff] [review]
Patch with checkin info - LAND ME

checkin was made by dvander

https://hg.mozilla.org/integration/mozilla-inbound/rev/edabc76c30f5

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/edabc76c30f5