Closed Bug 1081419 Opened 5 years ago Closed 5 years ago

WebGL2: Implement some miscellaneous parameters

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch bugXX-misc-parameters.patch (obsolete) — Splinter Review
This patch adds getParameter() support for MAX_UNIFORM_BLOCK_SIZE and MAX_VERTEX_UNIFORM_COMPONENTS. I'm not sure if we normally do conformance tests for things like this, but I've got one ready to go if so.
Attachment #8503521 - Flags: review?(jgilbert)
Yes, WebGL tries hard to cover everything with conformance tests. As you can see, WebGL 1 is covered quite extensively,
https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html
Attachment #8503521 - Flags: review?(jgilbert) → review+
Attached patch bug1081419-more-parameters.patch (obsolete) — Splinter Review
Two more parameters (Khronos PR is updated as well).
Attachment #8504295 - Flags: review?(jgilbert)
Comment on attachment 8504295 [details] [diff] [review]
bug1081419-more-parameters.patch

Review of attachment 8504295 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +156,5 @@
>  
>      if (IsWebGL2()) {
>          switch (pname) {
> +            case LOCAL_GL_MAX_SAMPLES:
> +            case LOCAL_GL_NUM_PROGRAM_BINARY_FORMATS:

We're not implementing program binaries in WebGL2, so drop this one. MAX_SAMPLES is fine.
Attachment #8504295 - Flags: review?(jgilbert) → review-
Attached patch bug1081419-misc-params.patch (obsolete) — Splinter Review
rolled-up
Attachment #8503521 - Attachment is obsolete: true
Attachment #8504295 - Attachment is obsolete: true
Attachment #8504936 - Flags: review+
Comment on attachment 8504956 [details] [diff] [review]
Patch with checkin info - LAND ME

checkin was made by dvander

https://hg.mozilla.org/integration/mozilla-inbound/rev/edabc76c30f5
Attachment #8504956 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/edabc76c30f5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.