Closed
Bug 1081419
Opened 10 years ago
Closed 10 years ago
WebGL2: Implement some miscellaneous parameters
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file, 3 obsolete files)
1.25 KB,
patch
|
bjacob
:
review+
cbook
:
checkin+
|
Details | Diff | Splinter Review |
This patch adds getParameter() support for MAX_UNIFORM_BLOCK_SIZE and MAX_VERTEX_UNIFORM_COMPONENTS. I'm not sure if we normally do conformance tests for things like this, but I've got one ready to go if so.
Attachment #8503521 -
Flags: review?(jgilbert)
Comment 1•10 years ago
|
||
Yes, WebGL tries hard to cover everything with conformance tests. As you can see, WebGL 1 is covered quite extensively, https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html
Assignee | ||
Comment 2•10 years ago
|
||
https://github.com/KhronosGroup/WebGL/pull/747
Updated•10 years ago
|
Attachment #8503521 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Two more parameters (Khronos PR is updated as well).
Attachment #8504295 -
Flags: review?(jgilbert)
Comment 4•10 years ago
|
||
Comment on attachment 8504295 [details] [diff] [review] bug1081419-more-parameters.patch Review of attachment 8504295 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLContextState.cpp @@ +156,5 @@ > > if (IsWebGL2()) { > switch (pname) { > + case LOCAL_GL_MAX_SAMPLES: > + case LOCAL_GL_NUM_PROGRAM_BINARY_FORMATS: We're not implementing program binaries in WebGL2, so drop this one. MAX_SAMPLES is fine.
Attachment #8504295 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 5•10 years ago
|
||
rolled-up
Attachment #8503521 -
Attachment is obsolete: true
Attachment #8504295 -
Attachment is obsolete: true
Attachment #8504936 -
Flags: review+
Comment 6•10 years ago
|
||
Attachment #8504936 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8504956 -
Flags: review+
Attachment #8504956 -
Flags: checkin?
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/edabc76c30f5
Comment 8•10 years ago
|
||
Comment on attachment 8504956 [details] [diff] [review] Patch with checkin info - LAND ME checkin was made by dvander https://hg.mozilla.org/integration/mozilla-inbound/rev/edabc76c30f5
Attachment #8504956 -
Flags: checkin? → checkin+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edabc76c30f5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•