"Update Scanner" add-on does not work on Nightly

RESOLVED FIXED in Firefox 36

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alice0775, Assigned: bholley)

Tracking

({regression})

35 Branch
mozilla36
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 unaffected, firefox35 unaffected, firefox36 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

5 years ago
[Tracking Requested - why for this release]:

Steps To Reproduce:
1. Install https://addons.mozilla.org/ja/firefox/addon/update-scanner/
2. Open View – Sidebar – Update Scanner (Alt+U)
3. Add new entry and click the entry

Actual Results:
No web content appears

An error shown in Error console:

SecurityError: The operation is insecure. diffPage.js:180


Expected Results:
web content appears


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e25cd3e8219
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140924000252
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35dcddea2c7a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140924001753
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1e25cd3e8219&tochange=35dcddea2c7a

Suspected: Bug 1030420
Reporter

Updated

5 years ago
Summary: Update Scanner does not work Nightly35.0a1 → "Update Scanner" add-on does not work Nightly35.0a1
Reporter

Updated

5 years ago
Summary: "Update Scanner" add-on does not work Nightly35.0a1 → "Update Scanner" add-on does not work on Nightly35.0a1
Reporter

Comment 1

5 years ago
Setting user_pref("dom.compartment_per_addon", false) fixes the problem
Assignee

Comment 2

5 years ago
This fixes the problem for me.
Attachment #8504886 - Flags: review?(bzbarsky)
Assignee

Updated

5 years ago
Assignee: nobody → bobbyholley
Comment on attachment 8504886 [details] [diff] [review]
Fall back to the addon global (if one exists) in GetEntryDocument. v1

r=me.  How easy is a test?
Attachment #8504886 - Flags: review?(bzbarsky) → review+
Assignee

Comment 4

5 years ago
Posted patch Tests. v1Splinter Review
Attachment #8506984 - Flags: review?(bzbarsky)
Comment on attachment 8506984 [details] [diff] [review]
Tests. v1

r=me
Attachment #8506984 - Flags: review?(bzbarsky) → review+
looks like this needs:
if (!entryWin && global) {
Flags: needinfo?(bobbyholley)
Assignee

Comment 8

5 years ago
(In reply to Bob Owen (:bobowen) from comment #7)
> looks like this needs:
> if (!entryWin && global) {

Whoops. Pushed a followup fix for the bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bd3640ea381
Flags: needinfo?(bobbyholley)
Looks like we need uplift here, please nominate for Aurora.
Flags: needinfo?(bobbyholley)
Assignee

Comment 11

5 years ago
(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #10)
> Looks like we need uplift here, please nominate for Aurora.

This feature is behind NIGHTLY_BUILD, so it shouldn't be enabled on Aurora.
Flags: needinfo?(bobbyholley)
Summary: "Update Scanner" add-on does not work on Nightly35.0a1 → "Update Scanner" add-on does not work on Nightly
You need to log in before you can comment on or make changes to this bug.