1081667 - change 'app domain' in details to 'Origin'; and (for privileged apps) show it above the fold

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Adrian Crespo]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141007073543

Steps to reproduce:

I was reviewing this app:
https://marketplace.firefox.com/reviewers/apps/review/navitime


Actual results:

The developer said:
<--------------------->
This application has the login function.
The login function, cookie is required.
In order to use the cookie, setting of the origin is required.
To the setting of the origin, must be "type": "privileged".

cf.
App manifest origin
https://developer.mozilla.org/en-US/Apps/Build/Manifest#origin

HTTP access control Access-Control-Allow-Origin
https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Origin
<--------------------->




Expected results:

It should use an explicit permission in order to set the origin.

Or at least, there should be a warning or message in the "Requested Permissions" section:
http://i.imgur.com/eCx2PP2.png

Comment 1

[Wil Clouser [:clouserw]]

The screenshot shows it's a privileged app.  We're triaging this, but we're not sure what this bug is asking for.  Andrew - is this something you've encountered?

Comment 2

[Adrian Crespo]

It is privileged because the owner set it, but there is no easy way for a reviewer to identify it quickly :\

Comment 3

[Andrew Williamson [:eviljeff]]

its shown under app details, but hidden under the 'more' fold by default.  I'm not 100% what problem we're trying to avoid though.

Comment 4

[Adrian Crespo]

After explaining my idea to [:eviljeff], he told me that It would be better to simply change the string "App domain" by "Origin" in the app description. I like that idea, it's better than mine.

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/672418aa545ecea8befc5096005b5d148176349b

STR:
- Submit a packaged app
- Go to the reviewers detail page for that app. The app origin should be shown, without needing to click to show more details

- Submit an hosted app
- Go to the reviewers detail page for that app. The app origin should be shown but this time you should need to click to show more details before seeing it.

Comment 6

[Madalin Cotetiu]

Verified as fixed in marketplace-dev.allizom.org
Packaged app:  http://screencast.com/t/9ofJFtCJ7a
Hosted app: http://screencast.com/t/QRRhmcUX