Closed Bug 1081697 Opened 10 years ago Closed 10 years ago

SIMD test cases: create comparison border cases for float32x4, int32x4, and float64x2 when ready

Categories

(Core :: JavaScript Engine, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ProgramFOX, Unassigned)

References

Details

In bug 948379 comment 26, bbouvier suggested to put comparison border cases (lessThan, lessThanOrEqual, greaterThan, greaterThanOrEqual, equal, notEqual, min, max) in a different bug (which is now this one). These test cases should also be implemented for float64x2 when it's ready, I'm currently working on it in bug 1031203. For equal and notEqual, the NaN/-0/Infinity/-Infinity tests have to be implemented, and for the other ones, -0/Infinity/-Infinity tests have to be implemented. Changes in SIMD.cpp have to be made to make these border cases work, hence float64x2 has to be finished first, because the float64x2 border cases will also have to rely on these SIMD.cpp changes.
Depends on: 1031203
See Also: → 948379
The test cases that are not equal/notEqual cannot get a NaN test case yet, see bug 1068028.
See Also: → 1068028
Depends on: 948379
See Also: 948379
Fixed by bug 1072368 (for comparisons) and bug 1094855 (for min/max). Tests related to float64x2 should be implemented in the bug that will introduce float64x2 in the interpreter.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
No longer depends on: 1031203
See Also: 1068028
You need to log in before you can comment on or make changes to this bug.