1081717 - [AccessFu] Introduce attribute for finger-up activation (like key role)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

This is needed for the quicknav menu. The actual items should have option soles so they can have states like aria-selected. When the user lifts their finger, the quicknav mode is selected.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Add attribute for finger-up activation in addition to key role.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8503792 [details] [diff] [review]
Add attribute for finger-up activation in addition to key role.

Review of attachment 8503792 [details] [diff] [review]:
-----------------------------------------------------------------

r=me(with the comment) for the actual code changes. I'm a little concerned about adding a new data attribute into the mix. Perhaps our role should be more generic instead?

::: accessible/jsat/Utils.jsm
@@ +476,5 @@
> +    if (aAccessible.role === Roles.KEY) {
> +      return true;
> +    }
> +    let dataset = aAccessible.DOMNode.dataset;
> +    return dataset && dataset.a11yActivateOnFingerUp;

If this is intended to be a boolean attribute (which probably makes most sense) then I would check for a11yActivateOnFingerUp not equal to null:
!!dataset && dataset.a11yActivateOnFingerUp !== null

As it is right now it will never return a boolean and instead undefined if there's no dataset, null if there's no attribute or a string value back that will be truthy be that "false" or "true" or falsy if no value is assigned to the attribute.

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df5e04296d12

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df5e04296d12