Closed
Bug 1081717
Opened 10 years ago
Closed 10 years ago
[AccessFu] Introduce attribute for finger-up activation (like key role)
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
Attachments
(1 file)
3.27 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
This is needed for the quicknav menu. The actual items should have option soles so they can have states like aria-selected. When the user lifts their finger, the quicknav mode is selected.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8503792 -
Flags: review?(yzenevich)
Comment 2•10 years ago
|
||
Comment on attachment 8503792 [details] [diff] [review] Add attribute for finger-up activation in addition to key role. Review of attachment 8503792 [details] [diff] [review]: ----------------------------------------------------------------- r=me(with the comment) for the actual code changes. I'm a little concerned about adding a new data attribute into the mix. Perhaps our role should be more generic instead? ::: accessible/jsat/Utils.jsm @@ +476,5 @@ > + if (aAccessible.role === Roles.KEY) { > + return true; > + } > + let dataset = aAccessible.DOMNode.dataset; > + return dataset && dataset.a11yActivateOnFingerUp; If this is intended to be a boolean attribute (which probably makes most sense) then I would check for a11yActivateOnFingerUp not equal to null: !!dataset && dataset.a11yActivateOnFingerUp !== null As it is right now it will never return a boolean and instead undefined if there's no dataset, null if there's no attribute or a string value back that will be truthy be that "false" or "true" or falsy if no value is assigned to the attribute.
Attachment #8503792 -
Flags: review?(yzenevich) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/df5e04296d12
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df5e04296d12
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•