1081764 - [Homescreen] When editing a homescreen icon's name and hitting Enter, the user becomes stuck on a blank page.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Joshua Mitchell (Inactive)]

Description:
When you enter edit mode and tap on an added icon you are taken to the edit name page. If you select on the name and bring up the keyboard then you hit enter (can be after editing the name or before) you are taken to a blank edit name page with unresponsive buttons and no way to exit except hitting the home button.


Repro Steps:
1) Update a Flame to 20141012115053
2) Add an app icon to Homescreen (Example: Facebook)
3) Long press the Homescreen icons to enter Edit Mode
4) Select the app icon added in step 2
5) Select the icon name to bring up the keyboard
6) Hit Enter

Actual:
User is taken to a white screen with a blank name-box and unresponsive X and Done icons (screenshot)

Expected:
Enter will behave the same as hitting 'done' - which means it will update the bookmark and exit the naming screen to return to the homescreen edit screen.

Additional Notes - This screen can also be encountered when initially adding an app or page to homescreen as it takes you to the 'add to homescreen' page where you can edit the name - and you can hit enter here. When you encounter it this way you will have to Home button out and won't successfully add the app / page to the homescreen.

To exit the dead-end blank screen the user can just hit the Home Button. Hitting the X or Done button has no effect. Opening Card view shows no evidence of the blank name screen.

Environmental Variables:
Device: Flame 2.2
Build ID: 20141012115053
Gaia: 3b81896f04a02697e615fa5390086bd5ecfed84f
Gecko: 199fb29c3467
Version: 35.0a1 (2.2)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Repro frequency: 100%
See attached: screenshot and logcat

-----------------------------------------------------------------------------------------

This issue also occurs on Flame KK 2.1, 

Device: Flame 2.1
Build ID: 20141011150624
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: e96a7a4f3bbe
Version: 34.0a2 (2.1)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------------------------------------------------

This issue does NOT occur in Flame KK 2.0

Actual Results - the edit link page has a different layout - the name and address section which do not react to hitting enter when editing

Device: Flame 2.0
Build ID: 20141010074705
Gaia: 6effca669c5baaf6cd7a63c91b71a02c6bd953b3
Gecko: 54ec9cb26b59
Version: 32.0 (2.0)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 1

[Joshua Mitchell (Inactive)]

Attachment: logcat_20141012_1637.txt

Comment 2

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: You end up on a blank page after pressing enter which is pretty terrible UX.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Pull request - Save bookmark on enter press

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Pull request - Save collection on enter press

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8504193 [details] [review]
Pull request - Save bookmark on enter press

Cristian - could you help me review this patch? Thanks!

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8504205 [details] [review]
Pull request - Save collection on enter press

Amir - could you help me review this Collections patch? Thanks!

Comment 7

[Joshua Mitchell (Inactive)]

striking regression-window tag - Spoke with Kevin G via IRC and he verified it is not needed here - he's already got this handled

Comment 8

[Gregor Wagner [:gwagner]]

Basic functionality is broken

Comment 9

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8504193 [details] [review]
Pull request - Save bookmark on enter press

LGTM, great work! Thanks a lot

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8504205 [details] [review]
Pull request - Save collection on enter press

Cristian - would you mind also giving this a quick review if you have time in case Amir does not get to it? It is quite similar to the bookmark update. Thank you!

Comment 11

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8504205 [details] [review]
Pull request - Save collection on enter press

LGTM and I did this part as well for collections so r+ from my point of view

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8504205 [details] [review]
Pull request - Save collection on enter press

Thanks Cristian!

Comment 13

[Kevin Grandon :kgrandon]

Bookmarks patch in master: https://github.com/mozilla-b2g/gaia/commit/65e192b16fcde47395759c1af687f451af1577e4
Collections patch in master: https://github.com/mozilla-b2g/gaia/commit/566999b6c61a1e1742168f769a9c3defa18a737f

Comment 14

[Kevin Grandon :kgrandon]

Comment on attachment 8504193 [details] [review]
Pull request - Save bookmark on enter press

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Likely 2.1 feature work.
[User impact] if declined: Users can be presented with a totally broken UI. I think they can recover from pressing the home button.
[Testing completed]: Integration tests written.
[Risk to taking this patch] (and alternatives if risky): Low risk - a relatively sandboxed change.
[String changes made]: None.

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8504205 [details] [review]
Pull request - Save collection on enter press

This same thing is happening with two different apps, so we should fix both. This is for the smart collections app. See comment 14.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/5e7f535b3599051ef484007fcfb057a7a4988117
v2.1: https://github.com/mozilla-b2g/gaia/commit/1d95ad15e3d222c97d552c79f152f11a5583bd07

Comment 17

[Elie]

Attachment: VIDEO0036.mp4

This issue has been fixed in flame 2.1 build:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141118001204
Version         34.0
attach video: [e-mail]