1081825 - [b2g-manifest]add fsck_modos repository for ffos

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[ying.xu]

we meet a bug, and found the reason is lacking of fsck_modos tool
STR:

launch camera, take a picture, press home button, 
remove the sdcard, then install the sdcard, wait for a few seconds
enter camera again, take a picture.

we can take the photo , but the phone can not be saved.

we find logs like belows:
09-30 15:23:37.137 <3>[   98.319507] c0 FAT-fs (mmcblk0p1): Filesystem has been set read-only
<3>[  276.926290]     clusters badly computed (108 != 107)
<3>[  276.931335]     File system has been set read-only
FAT-fs (mmcblk0p1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck

Our engineers add the tool fsck and re-test this bug, it's gone.
So I think mozilla should add fsck_modos repository to b2g-manifest.

diff --git a/sp6821a_gonk4.0.xml b/sp6821a_gonk4.0.xml
index 19cda09..e6cd0ac 100644
--- a/sp6821a_gonk4.0.xml
+++ b/sp6821a_gonk4.0.xml
@@ -69,6 +69,7 @@
   <project path="external/fdlibm" name="platform/external/fdlibm" />
   <project path="external/flac" name="platform/external/flac" />
   <project path="external/freetype" name="platform/external/freetype" />
+  <project path="external/fsck_msdos" name="platform/external/fsck_msdos" />
   <project path="external/genext2fs" name="platform/external/genext2fs" />
   <project path="external/giflib" name="platform/external/giflib" />

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Pull request (master)

Vincent, Partner request to add fsck_modos. Could you review this patch? Thanks!

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Pull request (1.3t)

Comment 3

[Vincent Liu[:vliu]]

Comment on attachment 8504090 [details] [review]
Pull request (master)

Looks good to me.

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

master: https://github.com/mozilla-b2g/b2g-manifest/commit/d2d42c944fc4a218c8152ec9827af0d5abfea11e
v1.3t: https://github.com/mozilla-b2g/b2g-manifest/commit/c97f943214359d37381cf73fcabe24172cfa7c6f

Comment 5

[Pete Moore [:pmoore][:pete]]

CC'ing mwu: looks like we need to roll this back as mirroring is not set up yet...

Comment 6

[Pete Moore [:pmoore][:pete]]

Same problem as we had in bug 1031378

Comment 7

[Pete Moore [:pmoore][:pete]]

I've backed this change out of the 1.3 branch for now - will investigate mirroring requirements, hopefully we can set that up, and re-land.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Pete Moore [:pete][:pmoore] from comment #7)
> I've backed this change out of the 1.3 branch for now - will investigate
> mirroring requirements, hopefully we can set that up, and re-land.

Pete, Thanks! Let's wait bug 1082466 resolved and land it again.

Comment 9

[Pete Moore [:pmoore][:pete]]

Thanks Kai-Zhen!

I agree that is the correct mapping we need - thanks for looking into this too.

I'm curious why we are not having a problem on master - to me it looks like the same mapping is required on master. Is it possible that on master, the tarako.xml file is not used, and no bumping takes places there?

Pete

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Pete Moore [:pete][:pmoore] from comment #9)
> Thanks Kai-Zhen!
> 
> I agree that is the correct mapping we need - thanks for looking into this
> too.
> 
> I'm curious why we are not having a problem on master - to me it looks like
> the same mapping is required on master. Is it possible that on master, the
> tarako.xml file is not used, and no bumping takes places there?
> 
> Pete

I think you are right. I also think the reason is that tarako.xml is not used by any build on master branch.

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

As depend bug is resolved, re-land and close this bug.
https://github.com/mozilla-b2g/b2g-manifest/commit/cb3b012caea45463d28851f6e648f1ebe3e8add5