1081851 - Add tabBrowser instance in the BrowserWindow class

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Daniel Gherasim]

As discussed in bug 1079725, we should add an instance of tabBrowser in the BrowserWindow class.

Also consider it being lazily loaded in the class.

Comment 1

[Daniel Gherasim]

Attachment: v1.patch

Comment 2

[Andrei Eftimie]

Comment on attachment 8504108 [details] [diff] [review]
v1.patch

Review of attachment 8504108 [details] [diff] [review]:
-----------------------------------------------------------------

Just 2 small issues.

::: firefox/lib/tests/testBrowserWindow.js
@@ +56,5 @@
> +  browserWindow.tabs.openTab();
> +
> +  expect.equal(browserWindow.tabs.length,
> +               length + 2,
> +               "Tabs have been successfully open");

With this please also add a closeAllTabs call in teardown

::: firefox/lib/ui/browser.js
@@ +43,5 @@
> +  if (!this._tabs) {
> +    this._tabs = new tabs.tabBrowser(this._controller)
> +  }
> +
> +  return this._tabs;

You can simplify this whole method:
> return this._tabs || new tabs.tabBrowser(this._controller);

Comment 3

[Daniel Gherasim]

Attachment: v2.patch

Thanks, updated and passed review to Henrik.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8504671 [details] [diff] [review]
v2.patch

Review of attachment 8504671 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/lib/ui/browser.js
@@ +38,5 @@
> + * Get the tabBrowser of the current browser window
> + *
> + * @returns {object} Tab browser of the window
> + */
> +BrowserWindow.prototype.__defineGetter__('tabs', function() {

nit: missing blank after 'function'

Comment 5

[Daniel Gherasim]

Attachment: v2.1.patch

Thanks Henrik!
Patch updated, applies cleanly on default, aurora & beta.

Comment 6

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8505309 [details] [diff] [review]
v2.1.patch

Review of attachment 8505309 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/16526b00657f (default)

I'll backport later today.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Backported:
http://hg.mozilla.org/qa/mozmill-tests/rev/5d33a7ea9cdf (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/e9e6fc1b5e80 (beta)