Closed Bug 1081951 Opened 10 years ago Closed 10 years ago

Remove unused awesomebar/places prefs from mobile.js

Categories

(Firefox for Android Graveyard :: General, defect)

35 Branch
All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: Margaret, Assigned: lviknesh, Mentored)

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

There's a lot of cruft in mobile.js from XUL fennec. We can at least start by cleaning up these unused awesomebar/places prefs.

See the prefs listed in here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#300

We'll just want to be careful to not remove any we actually *do* use, like "browser.urlbar.autocomplete.enabled" and "browser.urlbar.trimURLs".
Attached patch unused-prefSplinter Review
Assignee: nobody → lviknesh
Status: NEW → ASSIGNED
Attachment #8504200 - Flags: review?(margaret.leibovic)
Comment on attachment 8504200 [details] [diff] [review]
unused-pref

Review of attachment 8504200 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!
Attachment #8504200 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/31ec406e7001
Keywords: checkin-needed
Whiteboard: [lang=js] → [lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/31ec406e7001
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][fixed-in-fx-team] → [lang=js]
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.