1082039 - nsiHttpChannelInternal.allowSpdy is racy

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

As noted in bug 1072525 nsIHttpChannelInternal.allowSpdy is racy.

in particular, its possible a speculative connection will negotiate spdy and then get hooked up with a allowSpdy=false transaction.

The right way to fix that is to add nospdy to the conninfo hash.

Comment 1

[Patrick McManus [:mcmanus]]

https://tbpl.mozilla.org/?tree=Try&rev=5efcc693c08b

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: nsIHttpChannelInternal.allowSpdy is racy

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9026e7165e8

Comment 4

[Carsten Book [:Tomcat]]

sorry Patrick, had to back this out in https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=c7c0cb53949d since one of this changes caused https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3242159&repo=mozilla-inbound

Comment 5

[Carsten Book [:Tomcat]]

oh sorry, seems it was caused by the push before. Re-checkedin this changes in https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=c9d867500a39

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/73f9ba00bc74

Comment 7

[Günter]

Tested with FX
Version=36.0a1
BuildID=20141024030200

A CalDAV sync with Google Calendar to get ETags is failing with Error 400 Bad Request.

Requesting GCal for a CTag has a response of Status 207 No Reason Phrase

Setting prefs 
> network.http.spdy.enabled;false
solves the problem (for the moment), all responses are correct.

(should the patch https://hg.mozilla.org/mozilla-central/rev/73f9ba00bc74 solve that problem and is it already included in FX36.0a1?)

Comment 8

[Patrick McManus [:mcmanus]]

gunter - you're seeing bug 1072525 which is believed to be a google.com problem.

this patch would allow essentially a per-channel work around if the creator of the channel wished to use it. It doesn't opt any channels into that.