1082114 - Fix pre-setData() calls to .available()

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Steve Fink [:sfink] [:s:]]

Bug 1061288 fetch the ArrayBuffer length to use for .available(), which crashes if there is no buffer yet set.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Fix pre-setData() calls to .available()

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8504234 [details] [diff] [review]
Fix pre-setData() calls to .available()

Review of attachment 8504234 [details] [diff] [review]:
-----------------------------------------------------------------

This should also be backported, of course.

Comment 3

[Jeff Walden [:Waldo]]

I have a test in bug 991981 that, when landed, will somewhat incidentally test this.  So no need for a test here, I think.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4030d1c94b17

Comment 5

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8504234 [details] [diff] [review]
Fix pre-setData() calls to .available()

Approval Request Comment
[Feature/regressing bug #]: 1061288
[User impact if declined]: crash (null pointer deref) if abis.available() called early
[Describe test coverage new/current, TBPL]: on m-c for a day or two
[Risks and why]: low risk. Just an added null check.
[String/UUID change made/needed]: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a06058806b8b