1082151 - User is prompted to sign in every time they make a purchase

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: video

Connectivity: wifi with data roaming enabled
SIM used: Movistar SIM
Gaia/device: Flame/1.3 20140505203844 (ec462dc6)


steps to reproduce:
1. Search for :paid on payments-alt app
2. Sign in using FxA
3. Enter PIN
4. Completing the purchase is failing (diff bug)
5. Start the purchase flow again

expected behavior:
user doesn't need to sign in again

actual behavior:
user is prompted to sign in again.

Comment 1

[Stuart Colville [:muffinresearch]]

So looking into this it's clear why it's happening.

At the start of the process we hit this https://github.com/mozilla/spartacus/blob/master/public/js/views/init.js#L22 which looks at the session state. This defaults to false so we're always going to end-up seeing the login button screen.

So the next question is what do we have that's enough to say we're already logged-in? 

I'm thinking that looking at data-logged-in-user might be enough - at least this being present should define that we have a session in webpay. I'll tentatively put together a branch that works off that and we can decide if we need more than that in due course.

Comment 2

[Stuart Colville [:muffinresearch]]

Thinking about this more - we need to know about the user that's been signed in elsewhere - e.g. we can't just rely on there being an existing session. This way if the user logged-in changes on marketplace we want to be sure to know about that in webpay otherwise we'd have confusing issues where the user on marketplace is different to the one on webpay.

The fix for bug 1079529 should cover a big part of this.

Comment 3

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/commit/0e8ad72285c479673da6fd98eb0592578c29d307

Comment 4

[Iulian Timis]

Verified as fixed in MP-payments-alt app on FF 1.3 (Inari).
User is no longer prompted for login when making a new purchase.
Closing bug.