Closed
Bug 1082201
Opened 10 years ago
Closed 10 years ago
Turn off lock screen widget on Aurora
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 fixed, firefox36 wontfix)
VERIFIED
FIXED
Firefox 35
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file)
9.73 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The lock screen widget is neat but there are a few remaining issues that might be a bit too much for Aurora. i.e. bug 1072091 is the biggest. Fixing bug 1077590 would be nice as well (but I think our crashes should be gone...). I think we should probably let it back through 36 as well. If we change our mind, we can uplift/turn things back on in Aurora still.
Assignee | ||
Comment 1•10 years ago
|
||
This is a semi-manual backout, by basically removing some select code. It:
1.) Removes keyguard support from the widget
2.) Removes all keyguard checks in our codebase that should get us back to where we were before
3.) Removes the configureWindow calls that would let us show over the lockscreen.
We could do something a little simpler and just stub out these methods if you'd rather. I wanted to remove them so I'd know that I fixed all the entry points.
Attachment #8504344 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8504344 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Updated•10 years ago
|
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox35:
--- → fixed
status-firefox36:
--- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
Blocks: fennec-lockscreen
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•