1082218 - Window during in-app purchase too small to enter FxA credentials

Status: RESOLVED WORKSFORME

(Cloud Services :: Server: Firefox Accounts, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Connectivity: wifi
SIM used: none
Gaia/device: flame(kk)/2.0 [2014-09-04 7:42:57 506da297]


steps to reproduce:
1. Install http://marketplace.firefox.com/app/fxpay/ using the browser on your phone
2. With env set to payments.alt, buy one of the in-app products


expected behavior:
trusted UI is as wide as the phone screen

actual behavior:
Window too narrow to enter any credentials. user has to scroll down to see the input fields. See screenshot.

Comment 1

[Andy McKay]

Passing over to Chris, because this is an FxA screen, but I could be convinced its on our end.

Comment 2

[Chris Karlof [:ckarlof]]

Not clear what's going on here. I don't currently have access to a FxOS phone to verify, but based on the dimensions for the trusted UI given here

https://github.com/mozilla/fxa-content-server/issues/1271

the login seems to display properly in the Fx responsive view (although it seems that we could improve it a bit still). See attachment for screenshot. 

I'll continue to investigate. Jared, do you have time to help debug this?

Comment 3

[Chris Karlof [:ckarlof]]

Attachment: FxA login in 276px by 345px

Comment 4

[krupa raj[:krupa]]

I can consistently reproduce this on 1.3 as well.

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sure, happy to help. Chatting with krupa about detailed STR in IRC right now.

Note that FxA is not on device prior to 2.0, so that would be a separate bug or a bug in your code.

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Jared Hirsch [:_6a68] [NEEDINFO pls] from comment #5)
> Note that FxA is not on device prior to 2.0, so that would be a separate bug
> or a bug in your code.

Derp, I didn't realize Marketplace was using web-based FxA for versions < 2.0.

Still working on repro.

Comment 7

[krupa raj[:krupa]]

Happens on 1.4(20141014000205; git commit info; 2014-09-23 b06fee13) consistently but looks a little different. See http://cl.ly/image/0H160C360b35

I cannot reproduce this on 2.0 anymore.

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Could someone from QA help us try to reproduce?

I was not able to repro on flame on the latest 1.4 build. I'll attach screenshots.

STR:
1. install v123 base image from [1]
2. shallow gecko+gaia flash of latest v1.4 flame kk image, engineer build.
3. using the procedure from [2], flash the following prefs onto device:
  user_pref("dom.payment.provider.4.name", "paymentsalt");
  user_pref("dom.payment.provider.4.description", "payments-alt.allizom.org");
  user_pref("dom.payment.provider.4.uri", "https://payments-alt.allizom.org/mozpay/?req=");
  user_pref("dom.payment.provider.4.requestMethod", "GET");
  user_pref("dom.payment.provider.4.type", "mozilla-alt/payments/pay/v1");
4. restart the device after editing the prefs
5. open the browser and surf to http://marketplace.firefox.com/app/fxpay/ 
6. install the app
7. open the app (icon looks like a kiwi)
8. click the 'buy' button next to one of the items
9. fxpay window is displayed, click login button
10. fxa login is displayed, looks fine to me


Build info:
=================
Flash Information
=================
Your Target Build: PVT.v140.flame
URL:  https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-b2g30_v1_4-flame-eng/latest/
ENG Ver: true
Flash: Gaia, Gecko, 
Gaia      077d245f6795c01cb0b77bceec9da23274206a61
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/991ad4fc0342
BuildID   20141015000204
Version   30.0
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110


[1] https://intranet.mozilla.org/QA/B2G_Tips_and_Tricks#latest_OEM_JellyBean_Base_Image:_v123_.2B_fonts:
[2] https://developer.mozilla.org/en-US/Firefox_OS/Using_the_App_Manager#Using_a_real_device

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: step 1 - trusted UI looks properly-sized

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: step 2 - FxA login screen looks good to me

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Doh!

(In reply to Jared Hirsch [:_6a68] [NEEDINFO pls] from comment #8)
> 2. shallow gecko+gaia flash of latest v1.4 flame kk image, engineer build.

Not kk! flame jellybean image. that's a particularly unfortunate typo :-P

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Looking at the screenshot from comment 7, the empty space below the trusted UI overlay is the exact size of the keyboard.

Krupa, is it possible there's some sequence of touch events that is causing the keyboard to be hidden, but the screen isn't reflowed? Have you seen this before with the trusted UI?

Comment 13

[krupa raj[:krupa]]

Curioser and curioser.

I flashed my phone to the same 1.4 build and I do not see this issue anymore. I will try to flash it to today's build again and try my luck again.

Iulian,

Can you please try to reproduce this issue on 1.4 (flame preferably?). Thanks!

Comment 14

[Iulian Timis]

Attachment: fxpay_window.png

I am not able to reproduce this issue on FF OS 1.4 (Flame)