1082224 - Can't visit any pages in guest sessions

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We broke this entirely when RestrictedProfiles was fixed up recently.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

We now send all urls to the RestrictedProfiles check to see if we should load them. Before the java code would always reject all requests when in Guest mode. For url loads, it should reject based on the url.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We should be able to launch Fennec in guest mode for some really simple tests, right?

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8504365 [details] [diff] [review]
Patch

Review of attachment 8504365 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/RestrictedProfiles.java
@@ +174,5 @@
>          }
>  
> +        if (getInGuest()) {
> +            if (Restriction.DISALLOW_BROWSE_FILES == restriction) {
> +                return canLoadUrl(url);

Consider instead putting this at the *top*, and do:

  if (Restriction.DISALLOW_BROWSE_FILES.id == action) {
      return canLoadUrl(url);
  }

This'll get called on every page load for guest profiles, so we might as well avoid two method calls, three loop steps and three comparisons, just to figure out if we're trying to browse.

Comment 4

[Wesley Johnston (:wesj)]

Just out of interest, I timed this on my Nexus 5 by doing something like:

let start = performance.now();
if (ParentalControls....) {
}
console.log(performance.now() - start);

For cases where we don't restrict this takes around 0.1ms - 0.2ms (yes ms). For cases where we do it takes 35ms, all of which is in the call to docShell.displayLoadError.

Comment 5

[Aaron Train [:aaronmt]]

34 works for me? Did you mean 35?

Comment 6

[Richard Newman [:rnewman]]

This might be the cause of Bug 1083846.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/566e8300d241

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 8504365 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1080304
[User impact if declined]: Can't open any pages in guest sessions
[Describe test coverage new/current, TBPL]: Obviously, no? Testing profiles on tbpl is hard...
[Risks and why]: Low risk. Just moves some code to a different place. Could impact page load times, but in my testing the impact is tiny (sub ms).
[String/UUID change made/needed]: None.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/566e8300d241

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28707e4653e7

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Visiting pages  works ok in Guest Mode, so:
Verified fixed on:
Device: Nexus 5 (Android 4.4)
Build: Firefox for Android 36.0a1 (2014-10-22)

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Also visiting pages works ok in Guest Mode on latest Aurora:Firefox for Android 35.0a2 (2014-10-23)