WebGL2: Catch GL errors such as OUT_OF_MEMORY in texStorage entry points

RESOLVED FIXED in mozilla36

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

(Blocks: 1 bug)

Other Branch
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8504424 [details] [diff] [review]
Catch GL errors

This is something that we've long been doing for texImage2D, see CheckedTexImage2D. Forgot to do the same for texStorage entry points.
Attachment #8504424 - Flags: review?(jgilbert)
Attachment #8504424 - Flags: review?(jgilbert) → review+
Really we should assert that the only errors are NO_ERROR or OUT_OF_MEMORY. Any other error should be considered invalid at this time.
(Assignee)

Comment 2

3 years ago
Hrm, that would mean asserting on driver bugs. For example, after we have validated that a texStorage call is valid, a buggy driver could still reject it with, say, INVALID_OPERATION. Not sure that we would want to crash debug builds on that, given that our state tracking is already resilient to such driver bugs, with this patch.
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f524c6e6fc3
Assignee: nobody → bjacob
https://hg.mozilla.org/mozilla-central/rev/8f524c6e6fc3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(Assignee)

Updated

3 years ago
Blocks: 1071335
You need to log in before you can comment on or make changes to this bug.