Closed Bug 1082277 Opened 5 years ago Closed 5 years ago
GL2: Catch GL errors such as OUT _OF _MEMORY in tex Storage entry points
This is something that we've long been doing for texImage2D, see CheckedTexImage2D. Forgot to do the same for texStorage entry points.
Attachment #8504424 - Flags: review?(jgilbert)
Attachment #8504424 - Flags: review?(jgilbert) → review+
Really we should assert that the only errors are NO_ERROR or OUT_OF_MEMORY. Any other error should be considered invalid at this time.
Hrm, that would mean asserting on driver bugs. For example, after we have validated that a texStorage call is valid, a buggy driver could still reject it with, say, INVALID_OPERATION. Not sure that we would want to crash debug builds on that, given that our state tracking is already resilient to such driver bugs, with this patch.
Assignee: nobody → bjacob
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.