1082314 - define PSAPI_VERSION 1 to support xp.

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 6.4; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141012225757

Comment 1

[[e-mail]]

Attachment: xp.patch

Comment 2

[(Away)]

Why is this required? What happens if you don't include it? I've been compiling and running VS2013 builds on XP successfully for some time.

Comment 3

[[e-mail]]

(In reply to David Major [:dmajor] (UTC+13) from comment #2)
> Why is this required? What happens if you don't include it? I've been
> compiling and running VS2013 builds on XP successfully for some time.

I put WinMouseScrollHandler.cpp into unified building, which uses GetProcessImageFileName function, then I ran into issues with xp.

http://msdn.microsoft.com/en-us/library/ms683217%28VS.85%29.aspx

I thought it's a better idea to define it just in case.

Comment 4

[(Away)]

I see. I had just landed the compiler change on mozilla-inbound a few minutes before you filed this bug. It doesn't sound like a reason for a backout, we can fix this as a followup.

Comment 5

[(Away)]

Just to be sure, I tested the very first VS2013 tinderbox build: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1413255361/ It loads fine on XP (even SP2).

Comment 6

[Chris Peterson [:cpeterson]]

WFM as per comment 5.