Rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
As we did for the Matrix class, we should rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale.
(Assignee)

Comment 1

4 years ago
Created attachment 8504598 [details] [diff] [review]
part 1 - Rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale, leaving temporary inlines for the old names
Attachment #8504598 - Flags: review?(bas)
(Assignee)

Comment 2

4 years ago
Created attachment 8504600 [details] [diff] [review]
part 2 - Convert Mozilla code to use the new Matrix4x4::PreTranslate/PreScale method names
Attachment #8504600 - Flags: review?(bas)
(Assignee)

Comment 3

4 years ago
Created attachment 8504601 [details] [diff] [review]
part 3 - Remove the temporary Matrix4x4::Translate/Scale methods
Attachment #8504601 - Flags: review?(bas)
(Assignee)

Updated

4 years ago
Attachment #8504601 - Attachment is patch: true
Attachment #8504598 - Flags: review?(bas) → review+
Attachment #8504600 - Flags: review?(bas) → review+
Attachment #8504601 - Flags: review?(bas) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8504598 [details] [diff] [review]
part 1 - Rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale, leaving temporary inlines for the old names

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd0e534e1012
Attachment #8504598 - Flags: checkin+
(Assignee)

Comment 5

4 years ago
Comment on attachment 8504600 [details] [diff] [review]
part 2 - Convert Mozilla code to use the new Matrix4x4::PreTranslate/PreScale method names

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5c20e2b2c2
Attachment #8504600 - Flags: checkin+
(Assignee)

Comment 6

4 years ago
Comment on attachment 8504601 [details] [diff] [review]
part 3 - Remove the temporary Matrix4x4::Translate/Scale methods

https://hg.mozilla.org/integration/mozilla-inbound/rev/145557a8efdf
Attachment #8504601 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/cd0e534e1012
https://hg.mozilla.org/mozilla-central/rev/0f5c20e2b2c2
https://hg.mozilla.org/mozilla-central/rev/145557a8efdf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.