1082537 - Instantbird Windows build busted due to missing nss symbols

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Patrick Cloke [:clokep]]

(In reply to Patrick Cloke [:clokep] from bug 1080904, comment #0)
> After enabling MOZ_FOLD_LIBS for Instantbird, we're no longer able to build
> purplexpcom, which requires some functions not linked into nss3:
> > sipe-crypt-nss.obj : error LNK2019: unresolved external symbol _PK11_PubEncryptRaw referenced in function _sipe_crypt_rsa_encrypt
> > sipe-crypt-nss.obj : error LNK2019: unresolved external symbol _PK11_PubDecryptRaw referenced in function _sipe_crypt_rsa_decrypt
> > sipe-crypt-nss.obj : error LNK2019: unresolved external symbol _PK11_Verifyreferenced in function _sipe_crypt_verify_rsa
> > sipe-digest-nss.obj : error LNK2019: unresolved external symbol _PK11_RestoreContext referenced in function _sipe_digest_md5_end
> > sipe-digest-nss.obj : error LNK2019: unresolved external symbol _PK11_SaveContextAlloc referenced in function _sipe_digest_md5_end
> > purplexpcom.dll : fatal error LNK1120: 5 unresolved externals

Bug 1080904 was filed to allow the addition of these symbols via an extra .def file. This is currently in m-i and we'll need IB changes to take this into account.

Florian suggested modifying confvars.sh, which seems like the right place to do it. Does anyone know whether we have access to whether purple is enabled or not in here? (Or should we not care and just always add these symbols?)

Comment 1

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #0)

> Does anyone know whether we have access to whether purple is enabled
> or not in here? (Or should we not care and just always add these symbols?)

We don't care, let's always have them, otherwise installing the purplexpcom add-on on an Ib that wasn't initially built with purple would be impossible. And that makes me think that we may need to add these symbols on TB too :(.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This should fix it for Instantbird, we'll likely need a similar ptach for TB if we want to use SIPE with it.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8505581 [details] [diff] [review]
Patch v1

Review of attachment 8505581 [details] [diff] [review]:
-----------------------------------------------------------------

Ah yeah, it only matter for TB only if we want SIPE there. That makes it less urgent for TB I guess.

Comment 4

[Patrick Cloke [:clokep]]

http://hg.mozilla.org/comm-central/rev/05bb70d5b231

I'm going to leave this open to think about TB for the moment.

Comment 5

[Patrick Cloke [:clokep]]

I'm going to call this resolved and not build SIPE for Thunderbird in the Additional Chat Protocols extension.