1082625 - [Flame][Video] When camera is started by the video app, the mode switch displays incorrectly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[No-Jun Park [:njpark]]

Attachment: 2014-10-14-11-10-49.png

STR:
Open Video app, then press Camera icon to activate camera

Actual:
The camera app starts, and switches to video mode, but the mode switch shows video icon on both sides.

Version info:
Gaia-Rev        baaff455fd2c42c6319df77e1b77ee49c9e45ca5
Gecko-Rev       
Build-ID        20141014100256
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141010.070448
FW-Date         Fri Oct 10 07:04:59 EDT 2014
Bootloader      L1TC00011840

Comment 1

[No-Jun Park [:njpark]]

This does not reproduce in 2.1 build

Comment 2

[No-Jun Park [:njpark]]

Blocking reason:  broken UI that can confuse the user

Comment 3

[Russ Nicoletti [:russn]]

It seems this happens only when the camera app is not already running. When the camera app is running, this issue does not reproduce. No-jun, can you confirm?

Comment 4

[No-Jun Park [:njpark]]

(In reply to Russ Nicoletti [:russn] from comment #3)
> It seems this happens only when the camera app is not already running. When
> the camera app is running, this issue does not reproduce. No-jun, can you
> confirm?

That's correct, the switch is already moved to the right side where the camcorder icon is when camera app was running on the background already, and video app triggers to activate the camera app.

Comment 5

[No-Jun Park [:njpark]]

(In reply to Russ Nicoletti [:russn] from comment #3)
> It seems this happens only when the camera app is not already running. When
> the camera app is running, this issue does not reproduce. No-jun, can you
> confirm?

Actually, let me correct myself.  What I mentioned in Comment 4 happens only if camera was selected for camcorder previously.  If the camera app has the photo mode selected, the bug still occurs in master.

Comment 6

[Hema Koka [:hema]]

Blocking Reason: regression, broken button icons

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140919122247
Gaia: c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c
Gecko: 85ca2e799c13
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140919123746
Gaia: 3fdde421696be8b81c60b236c9fa7c9d8a6370fe
Gecko: 443c677ebe58
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia: 3fdde421696be8b81c60b236c9fa7c9d8a6370fe
Gecko: 85ca2e799c13

First Broken Gecko & Last Working Gaia - issue does NOT repro
Gaia: c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c
Gecko: 443c677ebe58

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c...3fdde421696be8b81c60b236c9fa7c9d8a6370fe

Caused by Bug 1066660.

Comment 8

[Joshua Mitchell (Inactive)]

Possibly broken by bug 1066660 - can you take a look Wilson?

Comment 9

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

REASON

We were attempting to set the switch position before the switch was in the DOM.

FIX

Wait till controls view is 'inserted' before setting up the the switch.

Comment 10

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8507825 [details] [review]
pull-request (master)

A couple small nits in the PR, but the main issue is that I don't see any new tests added. We should probably add some tests here before landing.

Comment 11

[Justin D'Arcangelo [:justindarc]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #10)
> Comment on attachment 8507825 [details] [review]
> pull-request (master)
> 
> A couple small nits in the PR, but the main issue is that I don't see any
> new tests added. We should probably add some tests here before landing.

Also, should we specify a version number in bower.json for "gaia-components/drag"?

Comment 12

[Wilson Page [:wilsonpage]]

Comment on attachment 8507825 [details] [review]
pull-request (master)

- Added test
- Fixed nits

Comment 13

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8507825 [details] [review]
pull-request (master)

Two additional comments in the PR. The only comment I'd like to see addressed before you land is that you're not using the `pointer` abstraction when removing event listeners. The other comment is more of an observation and doesn't need addressed here.

Comment 14

[Wilson Page [:wilsonpage]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #13)
> Comment on attachment 8507825 [details] [review]
> pull-request (master)
> 
> Two additional comments in the PR. The only comment I'd like to see
> addressed before you land is that you're not using the `pointer` abstraction
> when removing event listeners. The other comment is more of an observation
> and doesn't need addressed here.

I understand the second point, and tried a few approaches to keep that complexity in the library, but failed. I don't have too much time to spend on this unfortunately.

Comment 15

[Wilson Page [:wilsonpage]]

Comment on attachment 8507825 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/2d6d518018a9157d6fa3e2afe555645958449030

Comment 16

[sarsenyev]

Verified the issue is fixed on 2.2 Flame

When open "Camera" from the "Video" app, the switcher shows correct icons

Device: Flame 2.2 Master
BuildID: 20141124040203
Gaia: c5bad6d78c5fe168e3bb894fc5cb70902c9b19b1
Gecko: 8c02f3280d0c
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0