Closed Bug 1082729 Opened 5 years ago Closed 3 years ago

Roll out StoreMixin use to more places

Categories

(Hello (Loop) :: Client, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE
Blocking Flags:
backlog tech-debt

People

(Reporter: dmose, Unassigned)

References

Details

(Whiteboard: [tech-debt])

Right now, both the room store and loop stores are created in conversation:jsx, and then passed down through the AppControllerView.

Ideally, we'd like to push the store creation down at least into the AppControllerView, possibly even further.

There's been some speculation about how to do this, with the possibilities including in componentDidMount or, alternately, given the AppControllerView it's own store and adding an initialization action of some sort that would create and pass stores into the appropriate places.
Depends on: 1074686
No longer depends on: 1074686
Depends on: 1084228
backlog: --- → Fx38?
backlog: Fx38? → Fx37+
backlog: Fx37+ → Fx38?
backlog: Fx38? → tech-debt
Priority: -- → P4
Having re-read this and following on from bug 1106852 having been implemented, I think we should re-summarise this to roll-out use of the StoreMixin created in bug 1106852 to everywhere in the code.

This would eliminate the need to pass down the store mixins through all the components. If initialisation is still an issue later on, then I think it'll surface again at some stage.
OS: Mac OS X → All
Priority: P4 → P3
Hardware: x86 → All
Summary: clean up conversation.jsx:init(), AppControllerView, and friends → Roll out StoreMixin use to more places
Rank: 35
Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.