1082789 - [Loop] Contact name with we have shared an URL is not shown in the "Shared URLs" tab

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Attachment: Shared_link_tab.png

STR:
1. User A calls to a user B no registered in Loop (included in his Address Book with "Noloop" name) 
2. As User B is not registered in Loop application, the fallback mechanism to share a Loop URL with him is offered to User A
3. User A sends that URL to user B via SMS or via e-mail

Expected Result:
In the "Shared URL" tab of Device A, a new entry should appear including the name of B contact and the shared URL sent to him. See attachment

Current Result:
The name of contact B does not appear in the "Shared URL" entry just the identity (in this case an e-mail) with we have tried to make the Loop call. According to the ACs in US bug 1034605, the name of the contact ("Noloop") should be shown.

Comment 1

[Maria Angeles Oteo (:oteo)]

Attachment: Call_log.png

Just adding that when User B clicks on the shared URL sent by A, the Loop call is established and the incoming call in the Call log of device A shows correctly the B contact name

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Gracias

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8505384 [details]
Github pull request

changing reviewer suggested by Maria Angeles

Comment 4

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/45d4e5251c30b8a038a5873a438d1e56bb2e4586

Comment 5

[Javier de Prado]

as discussed previously, It's working fine, modifying contact's name from contact app. But, first time, and following the STR (above), I can reproduce it.

Devices: Flame (Gecko-b3429ef.Gaia-c6c6116), or FireE (firee-kk-v2.0-SW2E3-1)
Loop version: 28373ec

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request v2

thanks Fernando

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8505516 [details]
Github pull request v2

Thanks Cristian!

Comment 8

[Cristian Rodriguez (:crdlc)]

Thanks to you!

in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/87cbff6822d2ab660aaf2fda9bbc5ebe7f2eb8c7

Comment 9

[Javier de Prado]

Verified on flame and fireE
Loop version: 2168965