1082791 - About:certerror should be loaded remotely

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

The certerror page should be allowed to be loaded remotely in order to keep the association with the original docShell that attempted a load, so that things like docShell.failedChannel and the linked certs don't get lost due to a remote->non-remote transition.

We need to add it to the whitelist from bug 999239.

Marking for e10s-m4+ as that's what's marked for bug 1053456 (which this blocks).

Comment 1

[Dana Keeler (she/her) [:keeler]]

But, on the other hand, if about:certerror weren't loaded remotely, we wouldn't need to do the remote->non-remote translation, since the information we care about (the certificates presented by the server) is already known to the parent process, because that's where networking happens. From a security perspective, this is the preferable situation, since we shouldn't trust the child process to faithfully report this information.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/fx-team/rev/4ab8a1de595b

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Marking as QE- because bug 1053456 is already marked for QE verification

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=50231233&tree=Fx-Team

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8504974 [details] [diff] [review]
Patch

Review of attachment 8504974 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/E10SUtils.jsm
@@ +18,5 @@
>  
>      if (aURL.startsWith("about:") &&
>          aURL.toLowerCase() != "about:home" &&
>          aURL.toLowerCase() != "about:blank" &&
> +        !aURL.toLowerCase().startsWith("about:neterror")

missing '&&' here.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Sorry about that, fixed: https://hg.mozilla.org/integration/fx-team/rev/af47efe07009

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af47efe07009