Closed Bug 1082794 Opened 5 years ago Closed 5 years ago

Use Maybe instead of an optional constructor on AutoLockGC

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I guess Maybe didn't exist when AutoLockGC got added, but still a pretty weird way to implement the functionality.
Attachment #8504978 - Flags: review?(jcoppeard)
Comment on attachment 8504978 [details] [diff] [review]
use_maybe_for_autolockgc-v0.diff

Review of attachment 8504978 [details] [diff] [review]:
-----------------------------------------------------------------

Great.
Attachment #8504978 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/f94b063de925
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.