Closed
Bug 1082902
Opened 10 years ago
Closed 10 years ago
Debugging helpers
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: cjones, Assigned: cjones)
Details
Attachments
(2 files)
12.53 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
1.87 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
I wrote two patches to help me debug rendering problems. The first patch adds a new MOZ_GL_DEBUGGING macro to enable GL debugging, so that it can be easily turned on in opt builds. (Debug builds were a non-starter for my use case because they're too slow.) The second patch adds a publicly-exported helper function |mozilla_dump_image()| from gfxUtils. The helper accepts a pointer to raw bytes and image attributes and then dumps the image using DumpAsDataURI(). My use case for this was debugging the bowels of a GL implementation, from which it was quite inconvenient to directly use the DumpAsDataURI() helper. This helper would also be useful when debugging the internals of other libraries like camera, webrtc, fonts, skia, etc. I'm just tossing this code "over the wall", I'm not going to request review on these patches or fight for them to land. If no one is interested please just WONTFIX this bug now so we don't waste our time.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Updated•10 years ago
|
Attachment #8505168 -
Flags: review?(jgilbert)
Updated•10 years ago
|
Attachment #8505169 -
Flags: review?(jmuizelaar)
Comment 3•10 years ago
|
||
(In reply to Chris Jones [:cjones] temporarily active; ni?/f?/r? if you need me from comment #0) > I'm just tossing this code "over the wall", I'm not going to request review > on these patches or fight for them to land. If no one is interested please > just WONTFIX this bug now so we don't waste our time. I am interested, I'll do the fighting :)
Comment 4•10 years ago
|
||
Comment on attachment 8505168 [details] [diff] [review] Guard GL debugging by MOZ_GL_DEBUG macro Review of attachment 8505168 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLContext.h @@ +28,5 @@ > > +// Define MOZ_GL_DEBUG unconditionally to enable GL debugging in opt > +// builds. > +#if defined(DEBUG) > +# define MOZ_GL_DEBUG 1 Follow surrounding style. #ifdef... #define...
Attachment #8505168 -
Flags: review?(jgilbert) → review+
Comment 5•10 years ago
|
||
Addressed the comments and landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e283319cee6
Comment 6•10 years ago
|
||
Comment on attachment 8505169 [details] [diff] [review] Add mozilla_dump_image() helper exported from libxul Review of attachment 8505169 [details] [diff] [review]: ----------------------------------------------------------------- Sure.
Attachment #8505169 -
Flags: review?(jmuizelaar) → review+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8e283319cee6
Assignee: nobody → cjones.bugs
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 8•10 years ago
|
||
The second patch is r+ but didn't land. It's been sent to try incidentally a couple of times without incident. Reopening in case they're interest in landing, but feel free to re-close.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•10 years ago
|
||
woops, forgot about it, There we go https://hg.mozilla.org/integration/mozilla-inbound/rev/064ea6bcfa0b
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/064ea6bcfa0b
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•