1082917 - Large Cellbroadcast message getting clipped

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Anshul]

Attachment: clipped_cellbroadcast_message

[Blocking Requested - why for this release]: Poor user experience.

STR:
1. Send a large CBS message from the network such as "This should be a large message and is filling up some space 1234567abcdefghijklmnopqrstuvwxyz"

Observed: Message is getting clipped
Expected: The entire message should be displayed.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, can you help out here?

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25220

Comment 3

[Candice Serran (:cserran)]

poor user functionality ->blocker

Comment 4

[Anshul]

(In reply to Alberto Pastor [:albertopq] from comment #2)
> Created attachment 8506093 [details] [review]
> Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25220
I tested your patch and it does solve the problem. Thanks for the quick turn around.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8506093 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25220

Nice test, thanks!

Comment 6

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/78fe65635bff2b312ac10e05cc4ab4a9c9eaf145

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8506093 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25220

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: Large cbs message gets truncated
[Testing completed]: Manual + integration tests
[Risk to taking this patch] (and alternatives if risky): Low risk. CSS only with automated tests
[String changes made]: -

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/518a4c7974ed0687e801fee6f503620a77d8c6e9