1082936 - STK messages are seen overlapping each other

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Anshul]

Attachment: overlapping_stk_text

[Blocking Requested - why for this release]: Poor user experience

STR:
1. Send a STK proactive command SEND_SMS with some text, for example "Send SM"
2. Send another STK proactive command SEND_SMS or SEND_DTMF with some text, for example "Send DTMF".

Expected: UI should show the first message followed by the second message.
Observed: Both of the messages are visible on the top of each other.

Please check the attachment.

Comment 1

[Andrew Overholt [:overholt]]

2.1 CC blocker = 2.1+.

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Currently STK messages are not piped and attended as soon as they're received.
From my point of view this is a new feature, isn't it?

Comment 3

[Anshul]

Fernando, by message not being piped due to mean not queued such that the next message is behind the previous message in the display order?

Can we simply not clear the previous message before displaying the next one?

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

ni? to Fernando for comment 3.

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Anshul from comment #3)
> Fernando, by message not being piped due to mean not queued such that the
> next message is behind the previous message in the display order?
> 
> Can we simply not clear the previous message before displaying the next one?

Hi Anshul, I mean both.

Messages are not queued, so they are attended as they arrive. This is the first point of improve.

Also the Alerts, Input boxes, etc. use the same DIV [1] (showing or hiding it) so we can not display over the other one since each STK message is replacing the div content. This is the second point of improve ;)

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/index.html#L1115

Comment 6

[bhavana bajaj [:bajaj]]

:mancas, given comment #5, what is the effort required to resolve this in time to hit the 2.1 dates? In terms of timeline  we are exactly a week away in fixing CAF 2.1 CC bugs.

Comment 7

[Manuel Casas Barrado [:mancas]]

Attachment: Messages are piped

Comment 8

[Manuel Casas Barrado [:mancas]]

I think we can resolve this in time...The first approach of the patch is done, but we need to review it, and make changes if needed. So until the first revision I can't give you an estimated date.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8510877 [details] [review]
Messages are piped

f+ but with nits

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8510877 [details] [review]
Messages are piped

r+ since :frsela have feedback+'d the patch.

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/11bb4b4526df09ddc006fb8cd294fc29ceb23d77

Comment 12

[Manuel Casas Barrado [:mancas]]

Attachment: Patch v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New feature
[User impact] if declined: The user will see the STK messages overlapped
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]:No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/57401e89cf8dfb7cd6f6b589ed9a3a8974b05c9b

Comment 14

[Yeojin Chung [:YeojinC]]

Unable to verify as it is a back-end issue.

Comment 15

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Reverted on commit 6a24c8e4564432c804931ed85346f73425cf5290
Follow up in bug 1095802

Comment 16

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Reverted also in branch 2.1: 8495c5ebac772bba2b3b95f6f1e5c46b753ef7f4

Comment 17

[bhavana bajaj [:bajaj]]

Thanks for the backout, lets track these issues for 2.2 per : https://bugzilla.mozilla.org/show_bug.cgi?id=1095802#c14