Closed Bug 1082952 Opened 5 years ago Closed 5 years ago

WebGL2: Add support for TEXTURE_BINDING_3D

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: dvander, Assigned: dvander)

Details

Attachments

(1 file)

No description provided.
Need this to shim texImage3D in Emscripten until it's added to the official spec.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Attachment #8505140 - Flags: review?(jgilbert)
Comment on attachment 8505140 [details] [diff] [review]
bug1082952-texture-binding-3d.patch

Review of attachment 8505140 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +163,5 @@
>                  gl->fGetIntegerv(pname, &val);
>                  return JS::NumberValue(uint32_t(val));
>              }
> +
> +            case LOCAL_GL_TEXTURE_BINDING_3D: {

You need if (!WebGL2()) ErrorInvalidEnum
Comment on attachment 8505140 [details] [diff] [review]
bug1082952-texture-binding-3d.patch

Review of attachment 8505140 [details] [diff] [review]:
-----------------------------------------------------------------

:bjacob is correct.
Attachment #8505140 - Flags: review?(jgilbert) → review+
My hgrc wasn't showing enough context, but this whole switch is in an |if IsWebGL2()| test.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9413152ce85
https://hg.mozilla.org/mozilla-central/rev/e9413152ce85
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.