1082952 - WebGL2: Add support for TEXTURE_BINDING_3D

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1082952-texture-binding-3d.patch

Need this to shim texImage3D in Emscripten until it's added to the official spec.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8505140 [details] [diff] [review]
bug1082952-texture-binding-3d.patch

Review of attachment 8505140 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +163,5 @@
>                  gl->fGetIntegerv(pname, &val);
>                  return JS::NumberValue(uint32_t(val));
>              }
> +
> +            case LOCAL_GL_TEXTURE_BINDING_3D: {

You need if (!WebGL2()) ErrorInvalidEnum

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8505140 [details] [diff] [review]
bug1082952-texture-binding-3d.patch

Review of attachment 8505140 [details] [diff] [review]:
-----------------------------------------------------------------

:bjacob is correct.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

My hgrc wasn't showing enough context, but this whole switch is in an |if IsWebGL2()| test.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9413152ce85

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e9413152ce85