1082998 - [Midori][Call]The screen can not show a prompt"Emergency calls only"

Status: RESOLVED DUPLICATE of bug 1031652

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[sync-1]

FFOS 2.0
 
 DEFECT DESCRIPTION:
  the screen can not show a prompt "Emergency calls only"when call a no emergency number in the an emergency dial
  REPRODUCING PROCEDURES:
  1.set passcode lock
  2.enter to an emergency dial
  3.make a call  no emergency number"10010"
  4.the screen can not show a prompt "Emergency calls only"-->KO
 
  EXPECTED BEHAVIOUR:
  KO:the screen can  show a promote "Emergency calls only"
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  medium
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: vedio

Comment 2

[sync-1]

Attachment: jrdlog

Comment 3

[Doug Sherk (:drs) (inactive)]

It's possible that the RIL is not notifying Gaia that this is an emergency number. We haven't done any investigation on this yet, though. ccing Hsin-Yi in case she knows.

Comment 4

[Lingling Zhao]

I donot see any code for the prompt in emergency-call app.

Comment 5

[Doug Sherk (:drs) (inactive)]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #3)
> It's possible that the RIL is not notifying Gaia that this is an emergency
> number. We haven't done any investigation on this yet, though. ccing Hsin-Yi
> in case she knows.

Okay, I completely misinterpreted comment 0, and I thought that this bug was about the number "10010" not being treated as an emergency number when it should have been.

I confirmed that this is a problem on v2.0. This problem doesn't exist on master/v2.2, so it will be the responsibility of the devices team to uplift/fix it on v2.0m, if we decide to.

Removing Hsin-Yi from cc.

Comment 6

[Lingling Zhao]

So please merge the patch to v2.0 to fix it.

Thanks.

Comment 7

[Lingling Zhao]

Dear Doug Sherk,

Do you decide to merge the patch to V2.0?

Comment 8

[Doug Sherk (:drs) (inactive)]

Redirecting to the devices team.

Comment 9

[Jack Liu]

[Blocking Requested - why for this release]: It's regression from 1.3.

Comment 10

[Jack Liu]

Sorry for my mistake, it's not a regression, but the patch is needed for 2.0 branch.

Comment 11

[Rachelle Yang [:ryang][[e-mail]]]

Hi Etienne, 

Could you please kindly look into this issue ?
Triage to denominate it for now.

Comment 12

[Etienne Segonzac (:etienne)]

Looked at the gaia history but I don't see any good candidate for the uplift (ie. likely to fix this issue).
Might be a gecko change...

Johan, is there a good way to bisect between 2.0 and master?

Comment 13

[Johan Lorenzo [:jlorenzo]]

Discussed offline with Etienne, we need more information about where might be the regression. QA Wanted for a branch check. Can you please also test 1.4 with the v123 base image?

Comment 14

[Cody Roesch [:croesch]]

Tested with Full Flash on 319mb using Engineering builds

This bug repro's on Flame KK builds: Flame 2.0 KK, Flame 1.4 KK

Actual Results: No "Emergency Numbers Only" message seen when typing non emergency numbers into the Emergency Call dialer.

Repro Rate: 4/4

Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141020233820
Gaia: 63b56a7a7453726b9e12ad1afe02c68c83c5aeca
Gecko: 40584eecdc75
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20141002180522
Gaia: b06fee13c1d80bd2a463be1f2fb1d59169af9298
Gecko: ea144d59c01e
Version: 30.0 (1.4)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.2 KK, Flame 2.1 KK

Actual Result: Emergency Numbers Only message appears correctly.

Repro Rate: 0/4

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141020185822
Gaia: 457a54fc3200b80e4f5e1cd3acaa062309230732
Gecko: 29fbfc1b31aa
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141020202821
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Gecko: ee86921a986f
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 15

[Cody Roesch [:croesch]]

Correction, Flame 1.4 is JB not KK.

Comment 16

[Johan Lorenzo [:jlorenzo]]

I checked 2.1 gecko + 2.1 gaia => NO repro like said in comment 14, an error message is displayed.
> Gaia-Rev        db34a4b7edc0e08ede425f21f8a5b5e161e7dda8
> Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/65fe0274b476

I checked 2.1 gecko + 2.0 gaia => REPRO, nothing happens when I press the dial button after entering a regular phone number.
> Gaia-Rev        63b56a7a7453726b9e12ad1afe02c68c83c5aeca
> Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/65fe0274b476

I guess we need to uplift a gaia patch. Do you confirm, Etienne?

Comment 17

[Etienne Segonzac (:etienne)]

My best guess is that this is a duplicate from bug 1031652, so we should ask for approval on this one.

Comment 18

[Keven Kuo [:kkuo]]

Hi! Evelyn,

Could your team help to verify that this is a duplicate from bug 1031652? Thanks

--
Keven

Comment 19

[Jack Liu]

[Blocking Requested - why for this release]: It's potential blocker on carrier side when compare to Android phone or Iphone behavior .

Comment 20

[Evelyn Hung]

Chens, could you please spare time for checking this case? Since Luke's busy on other issues. Thank you.

Comment 21

[Sherman Chen [:chens] (inactive)]

Etienne is correct, this should be a duplicate of bug 1031652. 

But notice one thing, that patch contains string change to notify user that the number dialling is not an emergency number and we may not have those string translate properly on 2.0.

Comment 22

[Sherman Chen [:chens] (inactive)]

Attachment: wip

This patch is originally from attachment 8460804 [details] [review], which land on 2.1 and not able to uplift to 2.0.

Comment 23

[Wesly Huang (EPM)]

Impact emergency call function and patch is available in master, candidate to tag in coming Triage.

Comment 24

[Wesly Huang (EPM)]

[Triage] tag for 2.0.

Comment 25

[Keven Kuo [:kkuo]]

Hi! Chens,

Please help to merge to 2.0. Let me know if you have problem.
Thanks

--
Keven

Comment 26

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8510858 [details] [review]
wip

Hi Etienne, 

Could you help to review this patch and give some feedback? This patch is originally from bug 1031652.

Comment 27

[Sherman Chen [:chens] (inactive)]

I still have concern on this patch, this patch contains string change to show warning, but 2.0 is already at string freeze stage. If this is really a partner blocker, I would suggest partner take care translation work so it can show properly translated string.

Comment 28

[Etienne Segonzac (:etienne)]

Comment on attachment 8510858 [details] [review]
wip

I think we should mark this as a duplicate of bug 1031652 and uplift bug 1031652's patch.

Comment 29

[Sherman Chen [:chens] (inactive)]

Hi Etienne, bug 1031652's patch has conflict and can't uplift, so I take the same approach from bug 1031652 and create this PR for 2.0m branch, do you think this is ok?

Comment 30

[Etienne Segonzac (:etienne)]

(In reply to Sherman Chen [:chens] from comment #29)
> Hi Etienne, bug 1031652's patch has conflict and can't uplift, so I take the
> same approach from bug 1031652 and create this PR for 2.0m branch, do you
> think this is ok?

My recommendation would be to fix the conflict instead :)
(it's easier to keep track if we're not multiplying the branch-only fixes/bugs)

Comment 32

[Wesly Huang (EPM)]

Thanks to Sherman's remind in comment#27 and I support this. ni T2M.

Hi Jack: Even we got patch for this now, but please kindly take care of the translation work. Thanks for your understanding.

Comment 33

[Jack Liu]

(In reply to Wesly Huang from comment #32)
> Thanks to Sherman's remind in comment#27 and I support this. ni T2M.
> 
> Hi Jack: Even we got patch for this now, but please kindly take care of the
> translation work. Thanks for your understanding.

Many thanks, we shall take care of translation work while taking the patch.

Comment 34

[bhavana bajaj [:bajaj]]

[Blocking Requested - why for this release]:

(In reply to Wesly Huang from comment #24)
> [Triage] tag for 2.0.

I am not sure I'd block this for 2.0 as this isn't a new regression and is not a critical functional blocker to stop-ship the release on.

Over that, we should not be landing string changes at this point in 2.0.

Comment 35

[Wesly Huang (EPM)]

[Triage] Per internal discussion we need to this to 2.2 and follow in bug 1031652.