1083060 - Stop using XOW handlers for everything but Window and Location

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

An old quirk of XPConnect is that we we actually use the XOW handler for a wide variety of cases, and just rely on the filtering policy to make most things opaque. This works, but is kind of confusing, and we can do better from a defense-in-depth perspective.

This was confusing bz yesterday, which is reason enough to fix it now. Patches coming up.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Part 1 - Refactor the XOW access control code to use an enum rather than a char*. v1

Srsly.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 2 - Only use the XOW policy for Window and Location. v1

Comment 3

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=56ca0d2e60ee

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 8505311 [details] [diff] [review]
Part 1 - Refactor the XOW access control code to use an enum rather than a char*. v1

Review of attachment 8505311 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/AccessCheck.h
@@ +31,5 @@
> +    CrossOriginWindow,
> +    CrossOriginLocation,
> +    CrossOriginOpaque
> +};
> +CrossOriginObjectType TypeForCrossOriginObject(JSObject *obj);

Looks like you changed this to IdentifyCrossOriginObject in the deinition.

Comment 5

[Bobby Holley (:bholley)]

(In reply to Bob Owen (:bobowen) from comment #4)
> Looks like you changed this to IdentifyCrossOriginObject in the deinition.

Doh. Unified fail.

Comment 6

[Bobby Holley (:bholley)]

Attachment: Part 1 - Refactor the XOW access control code to use an enum rather than a char*. v2

Comment 7

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bf4a7efd1a20

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8505312 [details] [diff] [review]
Part 2 - Only use the XOW policy for Window and Location. v1

What is IdentifyCrossOriginObject?  I don't see it anywhere in the tree.

Do we really want to allow the OpaqueWithCall case when XrayForDOMObject?  I would think not.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8505312 [details] [diff] [review]
Part 2 - Only use the XOW policy for Window and Location. v1

> What is IdentifyCrossOriginObject?

Oh, its in the "later" part 1.  OK.

r=me modulo the WithCall bit.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8505341 [details] [diff] [review]
Part 1 - Refactor the XOW access control code to use an enum rather than a char*. v2

r=me

Comment 11

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/78f725c6441d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0373a2af17

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78f725c6441d
https://hg.mozilla.org/mozilla-central/rev/ba0373a2af17