1083142 - Reference to undefined property this.nextConnID in marionette-server.js

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The following error is outputted to gecko.log:

JavaScript strict warning: chrome://marionette/content/marionette-server.js, line 2975: ReferenceError: reference to undefined property this.nextConnID

Comment 1

[Jesal]

Hi Iam interested in this bug, could you please tell me more about this bug and where its causing issues? Thanks

Comment 2

[Andreas Tolfsen ❲:ato❳]

Hi Jesal, and welcome!

The marionette-server.js file that is referenced above is located in testing/marionette/marionette-server.js in the mozilla-central repo.  If you look at line 2976 (http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2976) it increments the nextConnID counter for every new client connection that is made.

The ReferenceError gets outputted to gecko.log when you make a new connection to Marionette.  The error is complaining that the property nextConnID on the this reference object doesn't exist.  If we look at line 2964 (http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2964) we can see it's defined as “nextConnId”, that is with a small “d” at the end; so the call on line 2976 is wrong.

This is a one character fix.

Comment 3

[Jesal]

(In reply to Andreas Tolfsen (:ato) from comment #2)
> Hi Jesal, and welcome!
> 
> The marionette-server.js file that is referenced above is located in
> testing/marionette/marionette-server.js in the mozilla-central repo.  If you
> look at line 2976
> (http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-
> server.js#2976) it increments the nextConnID counter for every new client
> connection that is made.
> 
> The ReferenceError gets outputted to gecko.log when you make a new
> connection to Marionette.  The error is complaining that the property
> nextConnID on the this reference object doesn't exist.  If we look at line
> 2964
> (http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-
> server.js#2964) we can see it's defined as “nextConnId”, that is with a
> small “d” at the end; so the call on line 2976 is wrong.
> 
> This is a one character fix.

Thanks Andreas, I will get working on a patch now and will upload it here when it's done. 
Will you assign the bug once the patch is done? 
Thanks for your advice. 

Jesal

Comment 4

[Andreas Tolfsen ❲:ato❳]

Done.  I'm ato in #ateam on IRC if you need any help.

Comment 5

[Jesal]

(In reply to Andreas Tolfsen (:ato) from comment #4)
> Done.  I'm ato in #ateam on IRC if you need any help.

Thanks, great to know you are on the IRC

Comment 6

[Jesal]

I am working on the patch and will have it uploaded today.
Thanks

Comment 7

[Jesal]

Attachment: bug1083142.patch This is hopefully the fix for the bug?

Hi Andreas, here is my patch. Please review this and check if I need to do anything else? If its ok, what happens next?

Thanks

Jesal

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8507765 [details] [diff] [review]
bug1083142.patch This is hopefully the fix for the bug?

Review of attachment 8507765 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this indeed fixes the problem!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9774579c63f1

Comment 10

[Jesal]

(In reply to Andreas Tolfsen (:ato) from comment #8)
> Comment on attachment 8507765 [details] [diff] [review]
> bug1083142.patch This is hopefully the fix for the bug?
> 
> Review of attachment 8507765 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, this indeed fixes the problem!

Thats great thanks Andreas. So what are the next steps? I understand that the patch will be pushed to fxteam first then loaded into Mozilla-central? do I need to do anything further to help this? 
Also Can I start working on another bug straight away, or do i need to pull change from Mozilla into my central directory?

Thanks

Jesal

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9774579c63f1