According to the feedback provided by Localization team we need to review and fix this issues in Loop mobile application: 1)Using placeholders so people can move the name of the application and other structures as "Terms of service" > welcome = Welcome to > byProceeding = By proceeding you agree with the > termsOfService = Terms of Service > notAUser = Not a Firefox Hello user yet 2)fix an issue related with the plural form that we were not taking into account > daysLeft = days left 3) a string change > ok=should be OK, not Ok
One more request: please add localization notes to the .properties file, especially if you add placeholders/variables that are not self-explanatory.
Comment on attachment 8505555 [details] Github pull request Before reviewing please ping me
Comment on attachment 8505555 [details] Github pull request Thanks Francesco
Comment on attachment 8505555 [details] Github pull request String-wise it looks good, even if I'd be happier with less HTML code in strings. Maybe worth asking feeback from :stas or :gandalf about the l10n.js bits.
in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d7cdd6fc56c8cf038df71811765085ee878a3dbe
Cristian, after talking with Massimo, we have agreed that this patch can be uplifted to 1.1. Could be so kind of doing it? Thanks a lot!!
in 1.1: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/dd4c02061ab77d1b394859a1696166a9a6f20c1a
Tested Flame eng v2.0 Gecko-dde9d61 Gaia-7b8df99 Loop version: 1.1 , 2e7c3c2