[Loop] Issues reported in Loop locales that need to be fixed before Localization teams starts working

VERIFIED FIXED

Status

Firefox OS
Gaia::Loop
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: oteo, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][blocking][loop in 1.1])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
According to the feedback provided by Localization team we need to review and fix this issues in Loop mobile application:

1)Using placeholders so people can move the name of the application and other structures as "Terms of service"

> welcome = Welcome to
> byProceeding = By proceeding you agree with the
> termsOfService = Terms of Service
> notAUser = Not a Firefox Hello user yet

2)fix an issue related with the plural form that we were not taking into account
> daysLeft = days left

3) a string change
> ok=should be OK, not Ok
(Reporter)

Updated

3 years ago
Blocks: 1083138
Summary: [Loop] Issues reported in Loop locales needed to be fixed before Loop teams starts working → [Loop] Issues reported in Loop locales that need to be fixed before Localization teams starts working
(Reporter)

Updated

3 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
One more request: please add localization notes to the .properties file, especially if you add placeholders/variables that are not self-explanatory.
(Assignee)

Comment 2

3 years ago
Created attachment 8505555 [details]
Github pull request
(Assignee)

Comment 3

3 years ago
Comment on attachment 8505555 [details]
Github pull request

Before reviewing please ping me
Attachment #8505555 - Attachment description: WIP → Github pull request
Attachment #8505555 - Flags: review?(borja.bugzilla)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8505555 [details]
Github pull request

Thanks Francesco
Attachment #8505555 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8505555 [details]
Github pull request

String-wise it looks good, even if I'd be happier with less HTML code in strings.

Maybe worth asking feeback from :stas or :gandalf about the l10n.js bits.
Attachment #8505555 - Flags: feedback?(francesco.lodolo) → feedback+
Attachment #8505555 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 6

3 years ago
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d7cdd6fc56c8cf038df71811765085ee878a3dbe
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Whiteboard: [mobile app][blocking][loop not in 1.1]
(Reporter)

Comment 7

3 years ago
Cristian, after talking with Massimo, we have agreed that this patch can be uplifted to 1.1. Could be so kind of doing it? Thanks a lot!!
Flags: needinfo?(crdlc)
Whiteboard: [mobile app][blocking][loop not in 1.1] → [mobile app][blocking][loop approved for 1.1]
(Assignee)

Comment 8

3 years ago
in 1.1:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/dd4c02061ab77d1b394859a1696166a9a6f20c1a
Flags: needinfo?(crdlc)
(Reporter)

Updated

3 years ago
Whiteboard: [mobile app][blocking][loop approved for 1.1] → [mobile app][blocking][loop in 1.1]
Tested 
Flame
eng
v2.0
Gecko-dde9d61
Gaia-7b8df99
Loop version: 1.1 , 2e7c3c2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.