1083168 - Regression causes shaders with uniforms of unnamed struct type to fail to compile and link

Status: RESOLVED WORKSFORME

(Core :: Graphics: CanvasWebGL, defect)

Description

[Matthew Amato]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141011015303

Steps to reproduce:

Visit https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shaders-with-uniform-structs.html


Actual results:

The test "Shaders with uniforms of unnamed struct type should compile and link successfully." fails.


Expected results:

The test should pass.  This did not happen in Firefox 32.

This is almost certainly ANGLE related and may be specific to the D3D9 back-end.  Chrome had a similar issue a while ago that has already been fixed.  See their issue for more details: https://code.google.com/p/chromium/issues/detail?id=401296

The original Chrome issue, and this new issue were both found via Cesium's unit tests; that test can be ran here: "http://cesiumjs.org/Cesium/Specs/SpecRunner.html?spec=Renderer%2FShaderProgram%20has%20a%20struct%20uniform."  I only include it for completeness as the WebGL conformance test supersedes it.

Comment 1

[Loic]

It's already fixed, I guess, test is green with FF36:
PASS Shaders with uniforms of unnamed struct type should compile and link successfully.

Comment 2

[Loic]

Working range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bd6e09f074e&tochange=790f41c631cc

Comment 3

[Matthew Amato]

(In reply to Loic from comment #1)
> It's already fixed, I guess, test is green with FF36:
> PASS Shaders with uniforms of unnamed struct type should compile and link
> successfully.

I just confirmed that this works in Aurora, 35.0a2 (2014-10-15) as well.