Closed Bug 1083198 Opened 5 years ago Closed 5 years ago

[B2G][SMS] Remove fallback for old gecko version in MessageManager.getMessages


(Firefox OS Graveyard :: Gaia::SMS, defect)

Not set


(Not tracked)

2.1 S8 (7Nov)


(Reporter: augustin.trancart, Assigned: augustin.trancart)



(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140924083558

Steps to reproduce:

In message-manager.js:getMessages, there's a fallback to deprecated MozSmsFilter for phone with an old version of gecko.

Expected results:

One day, we should remove it.
Not to be merged now, but when old gecko will reach end-of-life.
end-of-life basically means "when Augustin gets a new phone" :)
Attachment #8505509 - Flags: review?(felash)
Comment on attachment 8505509 [details] [review]
Link to Github pull-request:

r=me, but please rebase to the new master and push to your PR, so that we can have a proper Gij test run in the gaia-try results.

If everything looks fine (green) then add "checkin-needed" to the "keywords" line on the bug (near the top)

Thanks a lot to help cleaning up all this :)
Attachment #8505509 - Flags: review?(felash) → review+
Ok things are good except one integration test :

Should I worry about it?
Flags: needinfo?(felash)
I don't think it's related but I just restarted the test to be on the safe side.
Flags: needinfo?(felash)
Assignee: nobody → augustin.trancart
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.