Closed
Bug 1083215
Opened 10 years ago
Closed 10 years ago
Convert drawing of HTML image map area focus to Moz2D
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
2.33 KB,
patch
|
mattwoodrow
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
21.24 KB,
patch
|
mattwoodrow
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8505520 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8505521 -
Flags: review?(matt.woodrow)
Updated•10 years ago
|
Attachment #8505520 -
Flags: review?(matt.woodrow) → review+
Updated•10 years ago
|
Attachment #8505521 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8505520 [details] [diff] [review] part 1 - Add a Moz2D helper for snapping lines to device pixels https://hg.mozilla.org/integration/mozilla-inbound/rev/4fa7741a7e90
Attachment #8505520 -
Flags: checkin+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8505521 [details] [diff] [review] part 2 - Convert drawing of HTML image map area focus to Moz2D https://hg.mozilla.org/integration/mozilla-inbound/rev/3874e8dcb61d
Attachment #8505521 -
Flags: checkin+
Assignee | ||
Comment 5•10 years ago
|
||
Note than I moved StrokeSnappedEdgedRect into PathHelpers.h since I've ended up using that a lot in the patches for subsequent Moz2D porting bugs.
Comment 6•10 years ago
|
||
Comment on attachment 8505521 [details] [diff] [review] part 2 - Convert drawing of HTML image map area focus to Moz2D >+ static inline Color NSColorToColor(nscolor aColor) { >+ return Color(NS_GET_R(aColor)/255.0, >+ NS_GET_G(aColor)/255.0, >+ NS_GET_B(aColor)/255.0, >+ NS_GET_A(aColor)/255.0); >+ } Isn't this the same as Color::FromABGR?
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #6) > Isn't this the same as Color::FromABGR? Nice. Filed bug 1083761.
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4fa7741a7e90 https://hg.mozilla.org/mozilla-central/rev/3874e8dcb61d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•