Convert drawing of HTML image map area focus to Moz2D

RESOLVED FIXED in mozilla36

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 1 bug)

Trunk
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
Created attachment 8505520 [details] [diff] [review]
part 1 - Add a Moz2D helper for snapping lines to device pixels
Attachment #8505520 - Flags: review?(matt.woodrow)
Created attachment 8505521 [details] [diff] [review]
part 2 - Convert drawing of HTML image map area focus to Moz2D
Attachment #8505521 - Flags: review?(matt.woodrow)
Attachment #8505520 - Flags: review?(matt.woodrow) → review+
Attachment #8505521 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8505520 [details] [diff] [review]
part 1 - Add a Moz2D helper for snapping lines to device pixels

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fa7741a7e90
Attachment #8505520 - Flags: checkin+
Comment on attachment 8505521 [details] [diff] [review]
part 2 - Convert drawing of HTML image map area focus to Moz2D

https://hg.mozilla.org/integration/mozilla-inbound/rev/3874e8dcb61d
Attachment #8505521 - Flags: checkin+
Note than I moved StrokeSnappedEdgedRect into PathHelpers.h since I've ended up using that a lot in the patches for subsequent Moz2D porting bugs.
Comment on attachment 8505521 [details] [diff] [review]
part 2 - Convert drawing of HTML image map area focus to Moz2D

>+  static inline Color NSColorToColor(nscolor aColor) {
>+    return Color(NS_GET_R(aColor)/255.0,
>+                 NS_GET_G(aColor)/255.0,
>+                 NS_GET_B(aColor)/255.0,
>+                 NS_GET_A(aColor)/255.0);
>+  }

Isn't this the same as Color::FromABGR?
(Assignee)

Updated

3 years ago
Blocks: 776197
(In reply to Markus Stange [:mstange] from comment #6)
> Isn't this the same as Color::FromABGR?

Nice. Filed bug 1083761.
https://hg.mozilla.org/mozilla-central/rev/4fa7741a7e90
https://hg.mozilla.org/mozilla-central/rev/3874e8dcb61d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.