Closed Bug 1083376 Opened 5 years ago Closed 5 years ago

Drag and drop links to the bookmarks bar broke recently

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
36.1
Tracking Status
firefox35 --- unaffected
firefox36 --- verified

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR:

1) drag a url from the address bar down to the bookmarks bar

result: drop denied cursor
result: you should be able to drop shortcuts

console shows:

TypeError: PlacesUIUtils.nodeIsFolder is not a function
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/browserPlacesViews.js#1379
should be PlacesUtils.nodeIsFolder...
It's a regression from Bug 1068671. no e10s involved, just a typo on a poorly tested code path.
Blocks: 1068671
Points: --- → 1
tracking-e10s: ? → ---
Component: General → Bookmarks & History
Flags: firefox-backlog+
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: [e10s] Drag and drop links to the bookmarks bar broke recently → Drag and drop links to the bookmarks bar broke recently
No disrespect, but if it's just a typo can it be fixed right away?  I'm hoping this fixes my problem where I can't move bookmarks on the toolbar around.  I can only move them to the right of the last one.
Assignee: nobody → jmathies
Attachment #8506307 - Flags: review?(mak77)
Confirmed locally this fixes the problem.
Comment on attachment 8506307 [details] [diff] [review]
nodeIsFolder patch

Review of attachment 8506307 [details] [diff] [review]:
-----------------------------------------------------------------

I'm accepting this as an "emergency fix", but please file a bug in Firefox / Bookmarks & History to write a b-c test for this drag&drop action.
Attachment #8506307 - Flags: review?(mak77) → review+
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #5)
> Comment on attachment 8506307 [details] [diff] [review]
> nodeIsFolder patch
> 
> Review of attachment 8506307 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm accepting this as an "emergency fix", but please file a bug in Firefox /
> Bookmarks & History to write a b-c test for this drag&drop action.

No problem, thanks for the quick emergency approval.
Thanks guys.
https://hg.mozilla.org/mozilla-central/rev/a5f4b36c2cba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Iteration: --- → 36.1
Flags: qe-verify?
You need to log in before you can comment on or make changes to this bug.