Closed
Bug 1083376
Opened 10 years ago
Closed 10 years ago
Drag and drop links to the bookmarks bar broke recently
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox35 | --- | unaffected |
| firefox36 | --- | verified |
People
(Reporter: jimm, Assigned: jimm)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.18 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
STR:
1) drag a url from the address bar down to the bookmarks bar
result: drop denied cursor
result: you should be able to drop shortcuts
console shows:
TypeError: PlacesUIUtils.nodeIsFolder is not a function
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/browserPlacesViews.js#1379
|
Assignee | |
Updated•10 years ago
|
Keywords: regression,
regressionwindow-wanted
|
||
Comment 1•10 years ago
|
||
should be PlacesUtils.nodeIsFolder...
It's a regression from Bug 1068671. no e10s involved, just a typo on a poorly tested code path.
Blocks: 1068671
Points: --- → 1
tracking-e10s:
? → ---
Component: General → Bookmarks & History
Flags: firefox-backlog+
Keywords: regressionwindow-wanted
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: [e10s] Drag and drop links to the bookmarks bar broke recently → Drag and drop links to the bookmarks bar broke recently
|
||
Comment 2•10 years ago
|
||
No disrespect, but if it's just a typo can it be fixed right away? I'm hoping this fixes my problem where I can't move bookmarks on the toolbar around. I can only move them to the right of the last one.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Assignee: nobody → jmathies
Attachment #8506307 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Confirmed locally this fixes the problem.
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8506307 [details] [diff] [review]
nodeIsFolder patch
Review of attachment 8506307 [details] [diff] [review]:
-----------------------------------------------------------------
I'm accepting this as an "emergency fix", but please file a bug in Firefox / Bookmarks & History to write a b-c test for this drag&drop action.
Attachment #8506307 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #5)
> Comment on attachment 8506307 [details] [diff] [review]
> nodeIsFolder patch
>
> Review of attachment 8506307 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I'm accepting this as an "emergency fix", but please file a bug in Firefox /
> Bookmarks & History to write a b-c test for this drag&drop action.
No problem, thanks for the quick emergency approval.
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
|
||
Comment 8•10 years ago
|
||
Thanks guys.
|
||
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
|
||
Updated•10 years ago
|
Iteration: --- → 36.1
Flags: qe-verify?
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•