607.32 KB, application/zip
610.50 KB, application/zip
237.69 KB, patch
|Details | Diff | Splinter Review|
611.11 KB, application/zip
a final version of the icon is coming from mike manslaney and darrin
needing info to darrin and mike to so they have a bug to add the final icon to.
[Tracking Requested - why for this release]: We're advised that we need to make this change for the Fx34 release. We should have the icon tomorrow.
Created attachment 8508828 [details] Hello Glyphs Attached, the updated Hello assets.
You guys rock. Thanks!
(In reply to mmaslaney from comment #3) > Created attachment 8508828 [details] > Hello Glyphs > > Attached, the updated Hello assets. This is missing the toolbar-inverted graphic for Linux. Michael, can you attach that to this bug?
Created attachment 8508918 [details] Hello_Assets_v2.zip Updated. Thanks for the catch!
FYI: We're now using this bug to track the implementation of the icon update.
Created attachment 8509171 [details] [diff] [review] Patch
Comment on attachment 8509171 [details] [diff] [review] Patch Review of attachment 8509171 [details] [diff] [review]: ----------------------------------------------------------------- Purdy.
Hi Pauly -- Can you verify this in tomorrow's Nightly?
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #11) > Hi Pauly -- Can you verify this in tomorrow's Nightly? We've got more important bugs to test than visual design changes. This can uplift without QA testing in my opinion.
Comment on attachment 8509171 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: Hello needs new icon [User impact if declined]: We can't ship with the older icon (product requirement) [Describe test coverage new/current, TBPL]: manually tested and verified [Risks and why]: No risk outside of Hello, minimal risk to Hello [String/UUID change made/needed]: no strings
FWIW, on Linux the icon is a bit more blue compared to the other toolbar icons.
(In reply to Paul Silaghi, QA [:pauly] from comment #16) > FWIW, on Linux the icon is a bit more blue compared to the other toolbar > icons. Can you please file a bug for this and include a screenshot?
The fact that the 2nd and 3rd icon in the sprite look more round than the other icons makes a strange effect. Should I file a bug ?
Marketing designed the Hello glyph, so if it's still appearing "off" we'll need an updated, equal proportioned option.