1083396 - Update the icon to the final version

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[:shell escalante]

a final version of the icon is coming from mike manslaney and darrin

Comment 1

[:shell escalante]

needing info to darrin and mike to so they have a bug to add the final icon to.

Comment 2

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:
We're advised that we need to make this change for the Fx34 release.  We should have the icon tomorrow.

Comment 3

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Hello Glyphs

Attached, the updated Hello assets.

Comment 4

[Lee Tom]

You guys rock. Thanks!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to mmaslaney from comment #3)
> Created attachment 8508828 [details]
> Hello Glyphs
> 
> Attached, the updated Hello assets.

This is missing the toolbar-inverted graphic for Linux. Michael, can you attach that to this bug?

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Hello_Assets_v2.zip

Updated. Thanks for the catch!

Comment 7

[Maire Reavy [:mreavy]]

FYI: We're now using this bug to track the implementation of the icon update.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8509171 [details] [diff] [review]
Patch

Review of attachment 8509171 [details] [diff] [review]:
-----------------------------------------------------------------

Purdy.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/ba85c495df7e

Comment 11

[Maire Reavy [:mreavy]]

Hi Pauly -- Can you verify this in tomorrow's Nightly?

Comment 12

[u279076]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #11)
> Hi Pauly -- Can you verify this in tomorrow's Nightly?

We've got more important bugs to test than visual design changes. This can uplift without QA testing in my opinion.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba85c495df7e

Comment 14

[Maire Reavy [:mreavy]]

Comment on attachment 8509171 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Hello needs new icon
[User impact if declined]: We can't ship with the older icon (product requirement)
[Describe test coverage new/current, TBPL]: manually tested and verified
[Risks and why]: No risk outside of Hello, minimal risk to Hello
[String/UUID change made/needed]: no strings

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/140b821a6576
https://hg.mozilla.org/releases/mozilla-beta/rev/a80d4ca56309

Comment 16

[Paul Silaghi, QA [:pauly]]

FWIW, on Linux the icon is a bit more blue compared to the other toolbar icons.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Paul Silaghi, QA [:pauly] from comment #16)
> FWIW, on Linux the icon is a bit more blue compared to the other toolbar
> icons.

Can you please file a bug for this and include a screenshot?

Comment 18

[Tim Nguyen :ntim]

The fact that the 2nd and 3rd icon in the sprite look more round than the other icons makes a strange effect. Should I file a bug ?

Comment 19

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Hello_glyphs.zip

Updated spacing and dimension issues.

Comment 20

[Michael Maslaney [:mmaslaney] ([e-mail])]

Marketing designed the Hello glyph, so if it's still appearing "off" we'll need an updated, equal proportioned option.