Update the icon to the final version

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shell, Assigned: jaws)

Tracking

unspecified
mozilla36
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox34+ fixed, firefox35 fixed, firefox36 fixed)

Details

Attachments

(4 attachments)

(Reporter)

Description

3 years ago
a final version of the icon is coming from mike manslaney and darrin
(Reporter)

Comment 1

3 years ago
needing info to darrin and mike to so they have a bug to add the final icon to.
backlog: --- → Fx35+
Flags: needinfo?(mmaslaney)
Flags: needinfo?(dhenein)
(Reporter)

Updated

3 years ago
Whiteboard: [UX]
(Reporter)

Updated

3 years ago
backlog: Fx35+ → Fx34+
[Tracking Requested - why for this release]:
We're advised that we need to make this change for the Fx34 release.  We should have the icon tomorrow.
tracking-firefox34: --- → ?
status-firefox34: --- → affected
status-firefox35: --- → affected
status-firefox36: --- → affected
tracking-firefox34: ? → +
Assignee: nobody → mmaslaney
Flags: needinfo?(dhenein)
Created attachment 8508828 [details]
Hello Glyphs

Attached, the updated Hello assets.
Flags: needinfo?(mmaslaney)

Comment 4

3 years ago
You guys rock. Thanks!
(In reply to mmaslaney from comment #3)
> Created attachment 8508828 [details]
> Hello Glyphs
> 
> Attached, the updated Hello assets.

This is missing the toolbar-inverted graphic for Linux. Michael, can you attach that to this bug?
Flags: needinfo?(mmaslaney)
Created attachment 8508918 [details]
Hello_Assets_v2.zip

Updated. Thanks for the catch!
Flags: needinfo?(mmaslaney)
FYI: We're now using this bug to track the implementation of the icon update.
Assignee: mmaslaney → jaws
Whiteboard: [UX]
Created attachment 8509171 [details] [diff] [review]
Patch
Attachment #8509171 - Flags: review?(bmcbride)
Comment on attachment 8509171 [details] [diff] [review]
Patch

Review of attachment 8509171 [details] [diff] [review]:
-----------------------------------------------------------------

Purdy.
Attachment #8509171 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/integration/fx-team/rev/ba85c495df7e
Iteration: --- → 36.1
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
Whiteboard: [fixed in fx-team]

Updated

3 years ago
Status: NEW → ASSIGNED
Hi Pauly -- Can you verify this in tomorrow's Nightly?
Flags: needinfo?(paul.silaghi)
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #11)
> Hi Pauly -- Can you verify this in tomorrow's Nightly?

We've got more important bugs to test than visual design changes. This can uplift without QA testing in my opinion.
Flags: needinfo?(paul.silaghi)
https://hg.mozilla.org/mozilla-central/rev/ba85c495df7e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla35
Comment on attachment 8509171 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Hello needs new icon
[User impact if declined]: We can't ship with the older icon (product requirement)
[Describe test coverage new/current, TBPL]: manually tested and verified
[Risks and why]: No risk outside of Hello, minimal risk to Hello
[String/UUID change made/needed]: no strings
Attachment #8509171 - Flags: approval-mozilla-beta?
Attachment #8509171 - Flags: approval-mozilla-aurora?
Attachment #8509171 - Flags: approval-mozilla-beta?
Attachment #8509171 - Flags: approval-mozilla-beta+
Attachment #8509171 - Flags: approval-mozilla-aurora?
Attachment #8509171 - Flags: approval-mozilla-aurora+
status-firefox36: affected → fixed
https://hg.mozilla.org/releases/mozilla-aurora/rev/140b821a6576
https://hg.mozilla.org/releases/mozilla-beta/rev/a80d4ca56309
status-firefox34: affected → fixed
status-firefox35: affected → fixed
Target Milestone: mozilla35 → mozilla36

Updated

3 years ago
Depends on: 1088021
FWIW, on Linux the icon is a bit more blue compared to the other toolbar icons.
(In reply to Paul Silaghi, QA [:pauly] from comment #16)
> FWIW, on Linux the icon is a bit more blue compared to the other toolbar
> icons.

Can you please file a bug for this and include a screenshot?
Flags: needinfo?(paul.silaghi)

Comment 18

3 years ago
The fact that the 2nd and 3rd icon in the sprite look more round than the other icons makes a strange effect. Should I file a bug ?
Depends on: 1088508
Flags: needinfo?(paul.silaghi)
Created attachment 8513822 [details]
Hello_glyphs.zip

Updated spacing and dimension issues.
Marketing designed the Hello glyph, so if it's still appearing "off" we'll need an updated, equal proportioned option.

Updated

3 years ago
Depends on: 1099952
You need to log in before you can comment on or make changes to this bug.