1083427 - Failing (hidden) jetpack tests: Exposing privileged or cross-origin callable is prohibited

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dave Townsend [:mossop]]

Lots of jetpack tests are now failing since bug 1082450 landed

Comment 1

[Gary [:streetwolf52]]

Breaks the add-on https://addons.mozilla.org/en-US/firefox/addon/self-destructing-cookies/versions/0.4.7-pre2.

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0

Comment 2

[Boris Zbarsky [:bzbarsky]]

Dave, can you point me to a particular failing test, please?

Comment 3

[Gabor Krizsanits (INACTIVE)]

I talked to Matteo about this, https://tbpl.mozilla.org/php/getParsedLog.php?id=50292897&tree=Jetpack
is a good starting point, or https://tbpl.mozilla.org/?tree=Jetpack for that matter. I see some "Got an error: Exposing privileged or cross-origin callable is prohibited" I guess we should look into those.

Comment 4

[Gabor Krizsanits (INACTIVE)]

I accidentally cleared the needInfo flag... putting it back.

Comment 5

[Bobby Holley (:bholley)]

Attachment: Remove exposedProps from sandbox code. v1

Comment 6

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8506067 [details] [diff] [review]
Remove exposedProps from sandbox code. v1

Review of attachment 8506067 [details] [diff] [review]:
-----------------------------------------------------------------

Looks all good.

Comment 7

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fc0539e630bb

Comment 8

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #7)
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fc0539e630bb

Looks like this does indeed fix the JP tests.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e462b14ae1a

Comment 9

[Gary [:streetwolf52]]

Indeed it has fixed my problem with self-destructing cookies.

Comment 10

[Dave Townsend [:mossop]]

Awesome, thanks

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e7a7db91f62f3505993048075f8736fc650f5e69
Bug 1083427 - Remove exposedProps from sandbox code. r=gabor

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e462b14ae1a